Repository navigation
fix(piv): serve a synthesized Card Capability Container - #124
Merged
Merged
Conversation
|
Development firmware for this pull request: https://rskey.fob.wtf/preview?pr=124 The link always opens the latest successful preview build. |
TheMaxMur
approved these changes
Sep 27, 2026
TheMaxMur
approved these changes
Oct 16, 2026
Owner
|
Please sign your commits |
`5FC107` is a mandatory PIV object (SP 800-73-4 pt1 §3.1.1) that this card only held if a host had written one, so a freshly provisioned card answered 6A82 for it — and the Windows inbox PIV minidriver reads that object while opening a key container. The default follows the CHUID path rather than adding a second one: `get_data` reads flash first, and with nothing stored it serves the object the specification describes — Table 8's mandatory elements in table order, `F0`/`F1`/ `F2` zero-length (§3.1.1 defines no PIV values for them) and `F5` carrying the PIV data model number `0x10`. A host `PUT DATA` still overrides it, and an empty one falls back to the default again. `ccc.rs` holds the nine wire bytes beside their Table 8 provenance, with unit tests pinning the literal and the TLV walk; `docs/protocol.md` records the wire behaviour, and `docs/guides/piv.md` / `docs/windows.md` the host side. The applet is shared, so every board's image gains the object: bcdDevice -> 0x09DB.
The synthesized Card Capability Container arms add nine lines to `crates/rsk-piv/src/lib.rs`, which moves the five `Fs` delete-family call sites disposal is recorded against (858/1172/1207/1208/1210 -> +9). The dispositions themselves are unchanged; `scripts/deleter_gate.py` is green again.
`docs/platform-assumptions.md` is written from the spans in `assurance/platform.toml`, and the CCC work moves the code two of its rows cite: `crates/rsk-piv/src/lib.rs` 1328 -> 1337, `firmware/src/main.rs` 1022/960/968 -> 1025/963/971. The registry already held the new spans, so only the region generated from it was stale: this is `scripts/platform_gate.py --write`, two lines, and no change to the argument either row states.
Contributor
Author
|
All three commits are now signed (SSH, FIDO key) — GitHub shows them as Verified. The new CI runs on cc5f287 are marked "action required" and need your approval to start. Nothing else has changed: the rebase was patch-identical to the previous tip (range-diff shows = for all three). Thanks! |
IsayIsee
added a commit
to IsayIsee/RS-Key
that referenced
this pull request
Oct 20, 2026
The 2" board ships in all three postures, so the six published flavors are two boards x three postures: the GEEK and the 2" in default, `strong-pin` and `always-uv`. `bcdDevice` is 0x09DB, unchanged by this release: on this line it follows upstream. The tree is upstream 0.4.11 plus PR TheMaxMur#124 (the synthesized PIV Card Capability Container) and the dependabot bumps. The release notes are extracted from this section at tag time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Card Capability Container (
5FC107) is a mandatory PIV object(SP 800-73-4 pt1 §3.1.1). This card only held one if a host had written it, so a
freshly provisioned card answered
6A82for it — and the Windows inbox PIVminidriver reads that object while opening a key container, which is where a
certificate login comes back
NTE_BAD_KEYSET.How
The default follows the CHUID path rather than adding a second one:
get_datareads flash first, and when nothing is stored it serves the object the
specification describes — Table 8's mandatory elements in table order,
F0/F1/F2zero-length (§3.1.1 defines no PIV values for them) andF5carrying thePIV data model number
0x10(Appendix A). A hostPUT DATAstill overrides it,and an empty
PUT DATAfalls back to the default again.crates/rsk-piv/src/ccc.rsholds the nine wire bytes beside their Table 8provenance, with unit tests pinning both the literal and the TLV walk.
docs/protocol.mddocuments the synthesized default;docs/guides/piv.mdanddocs/windows.mdcover the host side;tests/interop/divergences.pyrecordsthe divergence (Yubico's SDK documents a factory CCC as present-but-empty).
bcdDevicemoves to
0x09DB. If the display-keys PR (feat: touchless display build for screen+button boards (display-keys) #123) lands first, this one needsthe neighbouring bump — its
bcdDeviceis the same value today.