Raiding clan removal - #30
Open
RandyChihuahua wants to merge 11 commits into
Open
Conversation
…clans, outlaw clans, and to remove their heroes. Adds a chaos raider clan to replace the usage of the kingdom-related chaos clan for the chaos portal. Removing the attributes allows the clans to not need heroes while still allowing them to function as clan references for the raiding parties spawned by the settlements, the template reference, banner for settlement + parties, etc... Save incompatible.
Party owner no longer points at clan leader. _template field removed from component as it resides with the clan definition. Fixes associated arguments in both classes. Adds explicative notes. Removes unneeded SaveableField. Renumbers fields as the removal is save-breaking anyways and integer ids are now consecutive.
RandyChihuahua
commented
Sep 6, 2026
…n an owner hero's clan. Removes overrides from inheriting classes. Removes unnecessary clan references as component.OwnerClan is directly accessible.
Their character objects are still existent, but no longer attached to any clans.
RandyChihuahua
marked this pull request as ready for review
September 8, 2026 16:56
…ather than querying all existing mobile parties.
…try. Requires tidying and being moved to its own namespace as it's irrelevant to religions.
Patch stands in for missing native null guard until fixed in base game.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.