Repository navigation
revert(chrome): the ground is a still again, no drift (#900, #905) - #929
Merged
Merged
Conversation
Owner, 2026-10-29: "remove that animation on the background of the app, I don't like it". Reverts both drift PRs, so plan 208 D5 holds again: nothing moves outside the Welcome screen. - ChromeGround is back to the display-sized still with no drift layer, timer or overhang. - Main no longer publishes session:take-running; the IPC contract, preload API, allowlists and takeRunning() helper go with it (the drift was their only user). - probe:ui-glass no longer holds Reduce Motion for the drift. - Design skill, glossary and docs/live-backgrounds.md say the ground is a still. The Welcome screen's live backdrop is unchanged.
Walkthrough
Merge Risk:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: reverting the chrome ground to a still image and removing drift. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 4 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This was referenced Oct 30, 2026
TheOrcDev
added a commit
that referenced
this pull request
Oct 30, 2026
Owner, 2026-10-29: after the drift came out (#929), "remove that highlight white thing from background completely". The frosted Liquid Chrome still that plan 208 put under every window is gone; windows paint the theme's plain solid (#070707 dark, #FAFAFA light). The chrome controls, the chrome rows and the Welcome screen's live backdrop are unchanged. - ChromeGround and its test are deleted, and WindowProviders no longer mounts it. A style guard now fails if anything imports the stills again. - The default window mode is { kind: 'solid', reason: 'default' } on every platform; the 'ground' GlassMode, the 'dark-always' reason and the 'chrome' WindowGround are gone. The bootstraps default data-ground to solid. VIDEORC_GLASS=0 and VIDEORC_GLASS=clear behave as before. - styles.css drops the [data-chrome-ground] rules and the ground comments. - chrome-ground-contrast.test.ts becomes window-contrast.test.ts: text tiers over the solid (and at Increase Contrast) and the chrome-row plates. - Probes: the Windows recovery gate and the comments-window probe expect the solid window; probe:ui-glass's checks (now lib/window-ground-checks.mjs) expect no ground image. - Design skill, glossary and docs/live-backgrounds.md say so. The phone remote still serves the stills (backend), out of scope here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner, 2026-10-29: "remove that animation on the background of the app, I don't like it".
Reverts #900 and #905. The Liquid Chrome ground under every window is a still again, so plan 208 D5 holds: nothing moves outside the Welcome screen.
ChromeGroundis the display-sized still again, with no drift layer, timer or 128 px overhang.session:take-running. The IPC contract entry,onTakeRunning(preload,VideorcApi, the aux-window allowlists) andtakeRunning()in capture-state go too, because the drift was their only user.probe:ui-glassno longer holds Reduce Motion for the drift.The only conflicts were in the design skill. Plan 0011's Stream Manager chrome-row bullet, which landed in between, is kept.
This also closes the open "drift self-pauses after a fresh launch" bug, because there's no drift left.
Verification
pnpm typecheck: greenchrome-ground,capture-state,electron-ipc-contract: 78/78probe:ui-glassand by-eyeSummary by CodeRabbit