7029 - improved exceptions (1/2)#115
Draft
petrknap wants to merge 1 commit into
Draft
Conversation
petrknap
added
documentation
petrknap
commented
Jul 21, 2026
Contributor
Author
There was a problem hiding this comment.
How to choose the base name and suffix for exceptions?
ApiServiceException+NotFoundApiServiceExceptionException+NotFoundExceptionApiServiceException+NotFoundException+NotFound
There already are NoAvailablePaymentMethod (without suffix), MissingExtensionException (with suffix) and ApiException (which blocks the best name for the root).
Member
There was a problem hiding this comment.
NotFoundApiServiceException looks nice.
I only hove one idea heck root name with interface suffix: ApiExceptionIterface.
Part 1/2 - refactoring + 404
petrknap
force-pushed
the
7029-improved-exceptions-404-only
branch
from
July 21, 2026 12:49
e378b26 to
2eb0077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1/2 - refactoring + 404
https://redmine.havelholding.cz/issues/7029