Skip to content

🔒 Security: Remove placeholder GitHub token #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheRealAshik wants to merge 1 commit into from
Closed

🔒 Security: Remove placeholder GitHub token #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composeApp/src/commonMain/composeResources/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@
<string name="add_pat_title">Add Account</string>
<string name="add_pat_description">Enter a GitHub Personal Access Token (PAT) with the required scopes to authenticate.</string>
<string name="add_pat_label">Personal Access Token</string>
<string name="add_pat_placeholder">ghp_xxxxxxxxxxxxxxxxxxxx</string>
<string name="add_pat_placeholder">REDACTED_PLACEHOLDER</string>

@gemini-code-assist gemini-code-assist Bot Jun 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using REDACTED_PLACEHOLDER as the placeholder text in the input field can look like a bug or a developer placeholder to end-users. If the previous placeholder ghp_xxxxxxxxxxxxxxxxxxxx was removed to avoid triggering automated secret scanners, using a generic prefix like ghp_... is a much better user experience while remaining safe from scanner alerts.

Suggested change
<string name="add_pat_placeholder">REDACTED_PLACEHOLDER</string>
<string name="add_pat_placeholder">ghp_...</string>

<string name="add_pat_save">Save Token</string>

<!-- Code Preview Placeholder Strings -->
Expand Down
Loading