fix: return an error instead of panicking when the frame stack empties#52
fix: return an error instead of panicking when the frame stack empties#52jtippett wants to merge 1 commit into
Conversation
execute() called frames.last().unwrap(), so guest input that emptied the frame stack aborted the whole host process. It now surfaces a RuntimeError to the caller. Running the TC39 Test262 suite (~48k inputs) went from aborting on the first such input to zero panics.
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello @jtippett |
Summary
A guest input that empties the VM frame stack panics
execute()(frames.last().unwrap()), aborting the whole host process. For an interpreter whose purpose is running untrusted, agent-generated code, guest input should never be able to take down the host. The VM now returns aRuntimeErrorto the caller instead.Two minimal reproductions (both abort the process on current master):
Note: with this fix the run surfaces
RuntimeError("no active call frame")rather than the guestcatchobserving the throw — the frame-unwinding accounting for callback frames looks like a separate, pre-existing issue (happy to file it with details). This PR only removes the process abort.Changes
frames.last().unwrap()dispatch sites return aRuntimeErroron an empty frame stack instead of panicking.tests/error_handling.rs, verified to abort the process without the fix.Test plan
cargo test)make lintclean (fmt + clippy-D warnings)Related issues
None open — found while running Test262 against the VM. We run this patch in production via ex_zapcode (Elixir bindings pinned to a zapcode-core fork).