fix: give switch a break frame so bare break cannot jump to program start#54
fix: give switch a break frame so bare break cannot jump to program start#54jtippett wants to merge 1 commit into
Conversation
…tart A bare break inside switch emitted Jump(0) with no patch target (switch pushed no loop frame), an infinite jump back to program start that ran until the allocation limit tripped. switch now registers a break-only frame that continue skips, and break/continue outside any loop or switch is a compile error instead of miscompiled code.
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
A bare
breakinsideswitchemittedJump(0)with no patch target —switchpushes no loop frame, so the jump went back to program start and ran until the allocation limit tripped.switchis listed as supported in AGENTS.md.Changes
switchregisters a break-only frame;continueskips it when searching for its target.break/continueoutside any loop or switch is now a compile error instead of miscompiled code.tests/control_flow.rs.Test plan
cargo test)make lintcleanRelated issues
None open. We run this patch in production via ex_zapcode.