Skip to content

feat: add global functions parseInt, parseFloat, isNaN, isFinite, Number, String, Boolean#57

Open
jtippett wants to merge 1 commit into
TheUncharted:masterfrom
jtippett:feat/global-builtins
Open

feat: add global functions parseInt, parseFloat, isNaN, isFinite, Number, String, Boolean#57
jtippett wants to merge 1 commit into
TheUncharted:masterfrom
jtippett:feat/global-builtins

Conversation

@jtippett

@jtippett jtippett commented Jul 9, 2026

Copy link
Copy Markdown

Summary

Agent-generated code constantly reaches for parseInt/parseFloat/isNaN/isFinite and the Number/String/Boolean conversion functions; today a bare call compiles to LoadGlobal → undefined → "x is not a function". All seven are pure computation with no sandbox surface.

Changes

  • The seven names are recognized at compile time (shadowable by a local of the same name — the same mechanism as external functions).
  • New CallBuiltin instruction dispatching to builtins::call_global_function.
  • Tests in tests/builtins.rs.

Test plan

  • Unit tests pass (cargo test)
  • make lint clean
  • Test262: built-ins/parseInt 0% → 73%, parseFloat 0% → 76%
  • CI passes

Related issues

None open. We run this patch in production via ex_zapcode.

…ber, String, Boolean

Bare calls to these compiled to LoadGlobal -> undefined -> "not a
function". They are now recognized at compile time (shadowable by a
local of the same name, like external functions) and dispatched via a
new CallBuiltin instruction to builtins::call_global_function.
Test262: built-ins/parseInt 0% -> 73%, parseFloat 0% -> 76%.
@jtippett
jtippett requested a review from TheUncharted as a code owner July 9, 2026 09:29
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@jtippett, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 550820e4-4dae-424a-8795-65537fccda58

📥 Commits

Reviewing files that changed from the base of the PR and between ebc06fd and bc6044d.

📒 Files selected for processing (5)
  • crates/zapcode-core/src/compiler/instruction.rs
  • crates/zapcode-core/src/compiler/mod.rs
  • crates/zapcode-core/src/vm/builtins.rs
  • crates/zapcode-core/src/vm/mod.rs
  • crates/zapcode-core/tests/builtins.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant