gh-68 Fixed bug with id creation based on time.#69
Open
No3x wants to merge 2 commits intoTheWebShop:masterfrom
Open
gh-68 Fixed bug with id creation based on time.#69No3x wants to merge 2 commits intoTheWebShop:masterfrom
No3x wants to merge 2 commits intoTheWebShop:masterfrom
Conversation
js/plugins/tabs.html
Outdated
|
|
||
|
|
||
| var id = 'bs_tab' + e.timeStamp; | ||
| var id = 'bs_tab' + guid(); |
Contributor
There was a problem hiding this comment.
Suggestion to add an underscore after 'bs_tab' for the id. So, var id = 'bs_tab_' + guid();
Contributor
Author
There was a problem hiding this comment.
I just replaced e.timeStamp and did not think about this. Thank you.
Added underscore as suggested by @emRae.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event.timeStampcontains fractions of a second. A dot in the html id attribute caused problems. => Replaced with guid function.