ci: run the frontend unit tests - #269
Merged
Merged
Conversation
The Frontend job ran typecheck and build but not vitest, so the 600+ unit tests, including the rule that every Tauri event subscription goes through src/lib/tauriEvent.ts (#268), only ran on developers' machines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Frontend job ran typecheck and build but never `pnpm test`, so the vitest suite (600+ tests on dev, including the source rule from #268 that every Tauri event subscription goes through `src/lib/tauriEvent.ts`) only ran locally. This adds a Unit tests step between Typecheck and Build.
🤖 Generated with Claude Code