Repository navigation
Upstreams: mark check-up findings on the upstream's row, drop the Check-up tab - #285
Merged
Merged
Conversation
…ck-up tab The Check-up tab sat beside three configuration tabs it had nothing in common with, and half of it repeated figures shown elsewhere (requests and failures in the 24-hour cell, TTFT and speed in their own column and on the overview). What only it had — a different model named in the answers, reported input well off the other upstreams, low cache reads — was easy to miss behind a fourth tab. Those three now appear as amber notes next to the upstream's name, after the existing problems (disabled, credential, sign-in, circuit), with the evidence and sample sizes on hover. The window is the last 7 days, what core's /upstreams/health counts by default. The flagging rules in checkup.ts are unchanged; the failure-rate flag goes, since the 24-hour cell already covers it. A disabled upstream shows only "Disabled". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Check-up tab sat beside three configuration tabs (upstreams, proxies, price sheets) it had nothing in common with, and half of it repeated figures shown elsewhere: requests and failures in the 24-hour cell, TTFT and speed in their own column and on the overview. The part only it had was easy to miss behind a fourth tab.
Now
CheckupTab.tsx,Checkup.i18n.ts).checkup.tsare unchanged;discrepancies()collects what to mark. The failure-rate flag is removed because the 24-hour cell already covers failures.GET /upstreams/healthis called with no window (core's default is the last 7 days) and refetched after requests finish, at most every 30 s.Checked:
pnpm typecheck,pnpm test(835),pnpm build. Also checked in the screenshot harness with injected findings, zh and en: labels on the right rows, tooltip contents and headings.The site's Lite docs (
features.md,keep-api-keys-from-relays.md) still describe the tab; they change with the next release.🤖 Generated with Claude Code