Skip to content

Fix the rotation comment: key limits follow the lineage #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fylorn merged 1 commit into from
Oct 20, 2026
Merged

Fix the rotation comment: key limits follow the lineage #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions crates/server/src/handlers/api_keys.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,11 +927,10 @@ pub async fn rotate_key(
.await;
let grace_period_ends_at = chrono::Utc::now() + chrono::Duration::hours(grace_hours);

// Generate new key. Rate-limit / budget rules attached to the
// OLD key id are NOT copied here — they live in `rate_limit_rules`
// / `budget_caps` keyed by api_key UUID. The follow-up phase
// ("limits attached to api_keys") will add an explicit copy step
// when rotation happens.
// Generate new key. Nothing to copy for limits: the key's
// rate-limit rules and budgets are attached to its `lineage_id`
// (`api_key_lineage` subjects, see `think_watch_common::limits`),
// and the new key keeps that lineage, so they carry over as is.
let generated = api_key::generate_api_key();

// The new key carries the old one's name verbatim — the chain is
Expand Down
Loading