404 page: the site header and footer follow the visitor's language too - #48
Merged
Merged
Conversation
GitHub Pages serves one 404 page for every address, built as an English page; its script switched the body to Chinese, but the header, the footer and the search box stayed English. SiteHeader, SiteFooter and SearchModal take a `bilingual` prop, set only by the 404 page. With it, every piece of text is rendered in both languages (a small Bi component), links carry data-localize for the page's script to point at /zh-CN, attributes such as aria-labels and the search box's texts carry their Chinese values in data-zh-attrs, and the language menu marks the visitor's language. Every other page renders exactly as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Pages serves one 404 page for every address, built as an English page. Its script switched the body to Chinese for Chinese visitors, but the header, the footer and the search box stayed English.
SiteHeader,SiteFooterandSearchModaltake abilingualprop, which only the 404 page sets. With it:Bicomponent;data-localize, so the page's script points them at/zh-CN;data-zh-attrs, which the script swaps in;Checked in headless Chromium:
/zh-CN/….tsc --noEmitis clean.🤖 Generated with Claude Code