Pull Request- Please review my code#16
Open
Brendonfatland wants to merge 3 commits intoThinkful-Ed:gh-pagesfrom
Open
Pull Request- Please review my code#16Brendonfatland wants to merge 3 commits intoThinkful-Ed:gh-pagesfrom
Brendonfatland wants to merge 3 commits intoThinkful-Ed:gh-pagesfrom
Conversation
aric87
reviewed
Sep 23, 2016
| var displayName = result.find(".display-Name"); | ||
| displayName.text(answer.user.display_name); | ||
| // Finds userprofile in template. adds in attr | ||
| var userProfile = result.find(".user-Profile"); |
Contributor
There was a problem hiding this comment.
Watch the quote's. You started off using single quotes, then switched to double. They should be consistent.
| $('.inspiration-getter').submit(function(e){ | ||
| e.preventDefault(); // | ||
| //Zero old results | ||
| $('.results').html(''); |
Contributor
There was a problem hiding this comment.
you should trim the input, that way you don't end up searching for %20javascript%20%20 with all that spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you