This repository was archived by the owner on Nov 11, 2024. It is now read-only.
feat: lookup auth header if token is not present in handshake#344
Open
dkadiog wants to merge 2 commits intoThream:developfrom
Open
feat: lookup auth header if token is not present in handshake#344dkadiog wants to merge 2 commits intoThream:developfrom
dkadiog wants to merge 2 commits intoThream:developfrom
Conversation
If a middleware sets the token for the request, its not present in the handshake and therefore not authorized. This supports also a auth header.
theoludwig
suggested changes
Nov 11, 2024
| @@ -42,6 +42,9 @@ export const authorize = (options: AuthorizeOptions): SocketIOMiddleware => { | |||
| return async (socket, next) => { | |||
| let encodedToken: string | null = null | |||
| const { token } = socket.handshake.auth | |||
Member
There was a problem hiding this comment.
Suggested change
| const { token } = socket.handshake.auth | |
| let { token } = socket.handshake.auth |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes this PR introduce?
If a middleware sets the token for the request, its not present in the handshake and therefore not authorized. This supports also a auth header.
List any relevant issue numbers
Is there anything you'd like reviewers to focus on?