Conversation
Replace the queue-based close request system with a timer-based scheduler that fires requests at their exact close_at time. This eliminates the sweep interval delay and improves precision. The scheduler uses a reconciliation pattern to arm, re-arm, and cancel timers based on the current database state, handling cases where requests are denied, closed, excluded, or rescheduled. Also added a default sweep time of 1 second to the config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RM-10
Description
Replace the queue-based close request system with a timer-based scheduler that fires requests at their exact close_at time. This eliminates the sweep interval delay and improves precision. The scheduler uses a reconciliation pattern to arm, re-arm, and cancel timers based on the current database state, handling cases where requests are denied, closed, excluded, or rescheduled. Also added a default sweep time of 1 second to the config.
Type of Change
Testing
Open a few tickets and send a close request for each of them, with some space in between them.
Checklist