Skip to content

RM-304: base claimer permissions on their support team instead of granting full access - #139

Merged
BenHall-1 merged 1 commit into
masterfrom
RM-304
Jul 25, 2026
Merged

RM-304: base claimer permissions on their support team instead of granting full access#139
BenHall-1 merged 1 commit into
masterfrom
RM-304

Conversation

@biast12

@biast12 biast12 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

RM-304

Description

When a ticket's claim settings restrict support from viewing or typing, claiming rebuilds the channel overwrites. In that rebuild the claimer was bundled in with the admins and given the full StandardPermissions set, ignoring whatever their support team's configured permissions allowed or denied.

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Testing

  • Claim with restrictive claim settings and a team that denies Mention Everyone → the claimer's overwrite denies it, Send Messages allowed.
  • Claim with a custom team → claimer gets that team's permissions, not the full set.
  • Unclaim or switch-panel under KeepAccess where the claimer loses panel access → the claimer keeps their existing overwrite.

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Keep the claimer's existing member overwrite when unclaiming switch-panel tickets, and pin claimer access explicitly when claimed tickets need regenerated permissions. Also refactor claimed-ticket overwrite generation to build and upsert the claimer overwrite consistently.
@biast12
biast12 requested a review from a team as a code owner July 25, 2026 17:14
@github-actions github-actions Bot added the type:bug Bug Fixes label Jul 25, 2026
@BenHall-1
BenHall-1 merged commit cade1b2 into master Jul 25, 2026
1 check passed
@BenHall-1
BenHall-1 deleted the RM-304 branch July 25, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants