Repository navigation
fix(deps): pin prosemirror-view 1.42.3+ and unblock the pnpm audit - #240
Merged
Merged
Conversation
Clears GHSA-c8x8-7fp4-3x9w (high; prosemirror-view paste XSS) by pinning prosemirror-view ^1.42.3, and pins prosemirror-model ^1.25.12 with it so the bundle keeps a single ProseMirror model. Ignores GHSA-vfj7-8cjw-p6xm (braces), which has no patched release and only reaches the build toolchain through @tailwindcss/cli. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MTy6g5wxP9DqjWJQshGz51
6 tasks done
Contributor
Cloudflare preview✅ Deployed |
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
block-kitchen | 87cd840 | Commit Preview URL Branch Preview URL |
Oct 12 2026, 02:36 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the Audit (pnpm) CI job green again. It has been red on
mainsince at least the 0.10.18 release run, so it fails on every PR. This implements the patch proposed in #237 (comment).prosemirror-view→ ^1.42.3 (pnpm override). This clears GHSA-c8x8-7fp4-3x9w (high; XSS via unvalidated clipboard slice context attributes on paste). It reaches the editor through@tiptap/extension-link > @tiptap/pm, whose range still admits the vulnerable versions. The lockfile now resolves 1.42.6.prosemirror-model→ ^1.25.12 (pnpm override), which the proposal didn't have. The patchedprosemirror-viewrequires^1.25.12, while@tiptap/pmwas locked to 1.25.11. Without the pin the lockfile held twoprosemirror-modelcopies. Two copies in one bundle make the list and quote commands throw (Can not convert <> to a Fragment). There is now exactly one copy of each.braces<=3.0.3) viapnpm.auditConfig.ignoreGhsas. It has no patched release. It's a build-time-only path (@tailwindcss/cli > @parcel/watcher > micromatch > braces) that only sees the repo's own glob patterns, and it isn't shipped to consumers.Each entry has a
//note inpackage.json, as the existingesbuildandundicioverrides do, saying when to remove it.Why
A red Audit job on every PR hides real new advisories. The
prosemirror-viewadvisory is a real paste XSS in the editor's own dependency.Overrides only shape this repo's lockfile, not what consumers install. Hosts must resolve
prosemirror-view>=1.42.3 themselves; tightknit-app already pins it (ENG-6316).Test plan
pnpm audit --audit-level=highreported two highs (braces,prosemirror-view). Now it exits 0 at the root (one finding ignored) and indemo/.pnpm typecheckpnpm lintpnpm test: 647 tests pass (522 unit, 125 Storybook browser), run project by project against a pre-provisioned Chromium. That includes the editor's list and quote command tests, which catch a duplicateprosemirror-model.pnpm build:cleanandpnpm demo:build🤖 Generated with Claude Code
https://claude.ai/code/session_01MTy6g5wxP9DqjWJQshGz51
Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.