Repository navigation
feat: accept rich_text_input min_lines and max_lines with slack-block-kit-validator 0.1.20 - #247
Merged
Merged
Conversation
…-kit-validator 0.1.20 Bumps the validator ^0.1.19 -> ^0.1.20, which allows the optional min_lines / max_lines (integers, 1-100) on rich_text_input. Previously a payload carrying either field was flagged as an unknown property and disabled Send. Tests cover accepted values, the 0/101/non-integer rejections, and that toSlackBlocks keeps both fields. Refs ENG-6395 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KtEQi8UpxDwUAahvmWnLVU
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
block-kitchen | fb6471d | Commit Preview URL Branch Preview URL |
Oct 17 2026, 04:29 AM |
Contributor
Cloudflare preview✅ Deployed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@tightknitai/slack-block-kit-validator^0.1.19->^0.1.20(TightknitAI/slack-block-kit-validator#116, released in TightknitAI/slack-block-kit-validator#117). The new version accepts the optionalmin_lines/max_linesfields (integers, 1-100) onrich_text_input.Why
Slack now documents
min_lines/max_lineson the rich text input element. On 0.1.19 the schema'sadditionalProperties: falseflagged either field as an unknown property, so a valid modal using them showed a validation error and disabled Send.Part of ENG-6395
Support
min_lines/max_lineson Slackrich_text_inputelementTest plan
pnpm typecheckpnpm lintpnpm test: 731 passed, Storybook browser project includedpnpm storybook(if UI changed): no UI changeNew
test/rich-text-input.test.tsruns the palette's rich text input throughtoSlackBlocksand the validator on a modal:toSlackBlockskeepsmin_lines/max_linesin the payload sent to Slack.{1, 100},{3, 20},min_linesalone andmax_linesalone validate clean. All four of these fail on 0.1.19 and pass on 0.1.20.min_lines: 0,max_lines: 101andmin_lines: 2.5are still rejected.Notes for reviewer
slack-web-api-client@1.1.15, predates it. So this PR doesn't touch theslack-web-api-clientdependency, and the input editor doesn't get Min lines / Max lines fields yet. Both can come once a release that includes chore(deps): Bump the production-dependencies group with 4 updates #113 is published. Until then, the fields can be set from the View JSON drawer.pre-pushhook was skipped because this container lacks the Playwright chromium-1243 build. The full suite above was run against the preinstalled Chromium through a throwaway config instead.Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.