chore: improve Linux desktop compatibility diagnostics - #42
Merged
Conversation
- verify.sh: neue Info-Sektion Session & Desktop (XDG_SESSION_TYPE, XDG_CURRENT_DESKTOP, WAYLAND_DISPLAY, DISPLAY), rein informativ - Clipboard-Checks session-abhängig: reine X11-Session verlangt xclip (wl-copy nur WARN), Wayland/headless verlangt wl-copy (xclip nur WARN) - ydotool fehlt: WARN statt FAIL — konsistent mit install.sh und dem Clipboard-only-Fallback der App - Hinweis, dass Fenster/Tray auch ohne input-Gruppe funktioniert - docs/setup.md: Kompatibilitätsmatrix (Kubuntu/Ubuntu/Mint/Lubuntu) als Diagnose-Referenz, ausdrücklich kein Supportversprechen - tests: 4 neue verify.sh-Tests (Session-Info, X11- vs. Wayland-Pflicht- Backend, ydotool-WARN)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e55ac5c9a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Blitztext Linux compatibility diagnostics for different Linux desktop/session environments without expanding official support promises.
Changes:
scripts/verify.shxclipwl-copyydotoolas a warning instead of a hard failure, because transcription and clipboard-only mode still workdocs/setup.mdVerification
python3 -m compileall app testsQT_QPA_PLATFORM=offscreen WHISPER_GUI_TESTS=1 python -m pytest -qgit diff --checkbash -n scripts/verify.shbash -n scripts/install.shshellcheck scripts/verify.sh scripts/install.shResult before push:
447 passedROADMAP.mdnot trackedScope
This is diagnostics/documentation/test hardening only.
Not changed:
Support note
The compatibility matrix is diagnostic, not a support guarantee. Mint and Lubuntu are documented as untested VM targets for follow-up validation.
Merge note
Do not merge before CI is green and final approval is given.