fix: make XXE protection test locale-resilient#2102
Merged
triceo merged 3 commits intoTimefoldAI:mainfrom Feb 15, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The GenericJaxbIOTest.readOverridingNamespaceIsProtectedFromXXE test asserted on the localized error message "DOCTYPE is disallowed", which fails on non-English JVM locales (e.g. de_DE: "DOCTYPE ist nicht zulässig"). Assert on the feature name "disallow-doctype-decl" instead, which is locale-independent and always present in the SAXParseException message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenericJaxbIOTest.readOverridingNamespaceIsProtectedFromXXEtest asserts on the English error message"DOCTYPE is disallowed", which fails on non-English JVM locales (e.g.de_DEproduces"DOCTYPE ist nicht zulässig")"disallow-doctype-decl"instead — the XML parser feature name, which is locale-independent and always present in theSAXParseExceptionmessageTest plan
de_DElocale (previously failed)en_USlocale (still works)🤖 Generated with Claude Code