Open
Conversation
- Add module directories for better code organization: - core/ - Core business logic - data/ - DataTable/DataView layer - ui/ - User interface components - widgets/ - Reusable UI widgets - state/ - State management - sql/ - SQL parsing and execution - api/ - External API interactions - utils/ - Utility functions - Add mod.rs files with documentation for each module - Add MODULE_STRUCTURE.md documentation - Update lib.rs to include new modules (alongside existing flat structure) - No code moved yet - just structure in place This sets up the foundation for gradually migrating from flat structure to organized modules over the next several branches.
- Moved documentation files from root to docs/ - Organized widgets into widgets/ module - Consolidated data layer in data/ module - Grouped UI components in ui/ module - Centralized SQL functionality in sql/ module - Created utils/ module for utilities - Established config/ module for configuration - Updated all import paths to use new module structure - Added backward-compatible re-exports in lib.rs - Fixed lazy_static usage with OnceLock - Removed experimental files (enhanced_tui_clean, modern_tui) This completes the module restructuring, creating a cleaner and more maintainable codebase architecture. All files are now organized by functionality rather than being flat in src/.
- Updated all imports to use sql_cli:: prefix for library modules - Fixed completer.rs to use correct parser path - Removed experimental modern TUI code - Main binary now compiles and runs successfully
- Added FilterSpec enum for different filter types (WhereClause, FuzzySearch, ColumnFilter) - Added SortOrder enum for sorting direction - Added DataType enum for column data types - Added ColumnStats struct for column statistics - These types support the DataTable/DataView architecture from v34
TimelordUK
added a commit
that referenced
this pull request
Aug 12, 2025
refactor(v35): Complete module restructuring and DataProvider foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.