Extract reusable MergeEngine#705
Open
frankmcsherry wants to merge 1 commit intoTimelyDataflow:master-nextfrom
Open
Extract reusable MergeEngine#705frankmcsherry wants to merge 1 commit intoTimelyDataflow:master-nextfrom
MergeEngine#705frankmcsherry wants to merge 1 commit intoTimelyDataflow:master-nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It attempting to robustify
half_joinI extracted a merger that doesn't have a chunker and doesn't only create batches through a builder. I ended up not using it, but I thought it would be good to record the effort and potentially just do (the fusion of chunker and builder seems artificial, and something better done as a wrapper rather than the core type, imo).