logging: hoist per-event work into log_one#796
Draft
antiguru wants to merge 1 commit into
Draft
Conversation
Bypass `log_many` entirely from `Logger::log` and split the per-event push+extract loop into a `log_one` method generic only over `T` (not the iterator type). Saves ~470 LLVM lines on the `event_driven` example by deduplicating per-iterator monomorphizations of `Logger::log_many` and `LoggerInner::log_many`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploration: bypass
log_manyfromLogger::logand split the per-event push+extract loop into alog_onemethod generic only overT(not the iterator type). Saves ~470 LLVM lines on theevent_drivenexample by deduplicating per-iterator monomorphizations ofLogger::log_manyandLoggerInner::log_many. Binary size of per-event-typeLogger::logcopies unchanged because LLVM still inlines theCapacityContainerBuilderVecDeque path; further wins would need changes in the container crate.