frontier: hoist rebuild check out of update_iter#797
Merged
frankmcsherry merged 1 commit intoMay 23, 2026
Conversation
Factor the per-update rebuild check in `MutableAntichain::update_iter` into a `requires_rebuild` helper generic only over `T`, and replace the two `frontier.iter().any(...)` calls with a single explicit `for` loop. This deduplicates the inlined `slice::Iter::any` bodies across `update_iter` monomorphizations and drops the per-call-site closure types. On the `event_driven` example, total LLVM lines drop by ~1600 (`update_iter` 758, `slice::Iter::any` ~1030, offset by 287 in the new helper). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Reads well to me; thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploration: factor the per-update rebuild check in
MutableAntichain::update_iterinto arequires_rebuildhelper generic only overT, and replace the twofrontier.iter().any(...)calls with a single explicitforloop. Deduplicates inlinedslice::Iter::anybodies acrossupdate_itermonomorphizations and drops the per-call-site closure types. On theevent_drivenexample, total LLVM lines drop by ~1600.