Skip to content

Add "Always in a new tab" checkbox #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rand-06 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add "Always in a new tab" checkbox #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9261e4f
Added "Always in new tab" checkbox
rand-06 Aug 25, 2026
7ca25e0
Merge remote-tracking branch 'origin/master'
rand-06 Aug 25, 2026
ff5b84c
cleanup of the prev commit
rand-06 Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion MainPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,10 @@ @media screen and (max-width: 1090px) and (min-width: 650.01px) {{
new H4(translation.linkOption),
translation.Selectables.Select(sel => new DIV(
new INPUT { type = itype.radio, class_ = "set-selectable", name = "selectable", id = $"selectable-{sel.PropName}" }.Data("selectable", sel.PropName), " ",
new LABEL { class_ = "set-selectable", id = $"selectable-label-{sel.PropName}", for_ = $"selectable-{sel.PropName}", accesskey = sel.Accel?.ToString().ToLowerInvariant() }._(sel.HumanReadable.Accel(sel.Accel))))),
new LABEL { class_ = "set-selectable", id = $"selectable-label-{sel.PropName}", for_ = $"selectable-{sel.PropName}", accesskey = sel.Accel?.ToString().ToLowerInvariant() }._(sel.HumanReadable.Accel(sel.Accel)))),
new INPUT { type = itype.checkbox, class_= "set-new-tab", id = "set-new-tab"},
new LABEL {for_ = "set-new-tab"}._(translation.newTab)
),
new DIV { class_ = "option-group" }._(new H4(translation.languagesOption), new DIV { id = "languages-option" }),
new BUTTON { class_ = "toggle-all-languages" }._(translation.languagesToggle)),

Expand Down
14 changes: 13 additions & 1 deletion Resources/KtaneWeb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ function initializePage(modules, initIcons, initDocDirs, initFilters, initSelect
try { filter = JSON.parse(lStorage.getItem('filters') || '{}') || {}; }
catch (exc) { }
let selectable = lStorage.getItem('selectable') || 'manual';
let currentTarget = lStorage.getItem('currentTarget') || '_self';
if (initSelectables.map(sel => sel.PropName).indexOf(selectable) === -1)
selectable = 'manual';
let preferredManuals = {};
Expand Down Expand Up @@ -1605,8 +1606,19 @@ function initializePage(modules, initIcons, initDocDirs, initFilters, initSelect

// This also calls updateFilter()
setSelectable(selectable);

$('input.set-selectable').click(function() { setSelectable($(this).data('selectable')); });
$('input.set-new-tab').change(function(event){
currentTarget = event.target.checked?"_blank":"_self";
lStorage.setItem('currentTarget', currentTarget);
for (let el of document.getElementsByClassName("modlink")){
el.setAttribute('target', currentTarget);
}
});
$('input.set-new-tab')[0].checked = (lStorage.getItem('currentTarget') === "_blank");
for (let el of document.getElementsByClassName("modlink")){
el.setAttribute('target', currentTarget);
}
$('input.filter').click(function() { updateFilter(); });
$("input.results-mode").click(function() { setResultsMode(this.value, resultsLimit); });
$("input#results-limit").change(function() { setResultsMode(resultsMode, this.value | 0); });
Expand Down
1 change: 1 addition & 0 deletions TranslationInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ private static TranslationInfo makeDefault()
public string selectableSource = "Source code";
public string selectableSourceClone = "Source code (clone)";
public string selectableTutorial = "Tutorial videos";
public string newTab = "Always open in new tab";
public string displayOption = "Display";
public string displayOriginalName = "Original name";
public string displayOriginalNameTooltip = "Displays the original (English-language) name in addition to the translated name.";
Expand Down