Harden channel auth, file safety, and update integrity#44
Harden channel auth, file safety, and update integrity#44coreyone wants to merge 2 commits intoTinyAGI:mainfrom
Conversation
|
Thanks for the great PR. Sender allowlist with pairing approach implemented in #43 Will review the rest. |
|
Thanks for the security-focused improvements in this PR. I ran local verification and found a few important issues. Findings1. Blocking: update path fails for existing releases without checksum assetArea: Observed behavior (local):
Why this matters: This breaks upgrade compatibility for users on older release assets. Suggestion: Add backward-compatible fallback behavior (e.g. prompt user to continue without checksum), or ensure all target releases include checksum assets. 2. Non-blocking (important): config behavior mismatch for outbound file path overrideArea: queue processor vs channel clients
Issue: The config implies outside-files-dir outbound paths can be allowed, but Telegram client still blocks them. Repro (local, Telegram):
Why this matters: Runtime behavior does not match config semantics. Suggestion: Align policy across layers (apply override in channel clients too, or remove/clarify the setting). 3. Non-blocking: setup now hard-requires
|
|
Thanks for the review — I’ve pushed follow-up fixes in 570b463. Addressed items:
�[0;34m[1/6] Checking dependencies...�[0m �[0;34m[2/6] Choosing installation directory...�[0m �[0;34m[3/6] Selecting installation method...�[0m �[0;34m[4/6] Downloading TinyClaw...�[0m �[0;34m[5/6] Installing dependencies...�[0m �[0;34m[6/6] Installing CLI command...�[0m
|
|
Follow-up is pushed in Addressed:
|
|
Re-checked follow-up commit
Thanks for the follow-up; this resolves my previous review findings. |
Summary
This PR fixes the full security/code-review audit set by hardening chat ingress, agent invocation, outbound file handling, and bundle update/install integrity.
What changed
[send_file: ...]paths to.tinyclaw/filesby default (realpath checks + defense in depth).allow_dangerous_agent_flags,TINYCLAW_ALLOW_DANGEROUS_FLAGS).jqsafely (no raw interpolation) and add security prompts/defaults.Validation
bash -npassed for modified shell scripts.npm run buildpassed.Notes