Conversation
Author
|
Out of curiosity, why don't we use a non-locking baseline component library and iterate on it? like shadcn or something, I think there is room for UI/UX improvements, if you're interested in this kind of improvements let me know I can pitch a prototype for whats in my mind. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 26_ux #96 +/- ##
==========================================
+ Coverage 67.42% 68.34% +0.91%
==========================================
Files 62 62
Lines 3635 3680 +45
==========================================
+ Hits 2451 2515 +64
+ Misses 1184 1165 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried the #58 dashboard and found a few bugs and did a few improvements along the way:
credentials: 'include'from the cookie-auth days, the browser rejected when the server answered withAccess-Control-Allow-Origin: *. So since the auth is token based, i've removed it.useEntityFormused its Zod schema only as a validator, so the schema's transforms never ran and raw form strings went straight to Postgres. Now it parses on submit.declare_exreturnedstateas a raw string, crashingQueue.pack(), andjson_dumpscouldn't serialize sets which killed the websocket stream event.