Restore PyPI classifiers and license metadata in pyproject.toml (fixes #131) - #138
Open
Rehan30g wants to merge 1 commit into
Open
Restore PyPI classifiers and license metadata in pyproject.toml (fixes #131)#138Rehan30g wants to merge 1 commit into
Rehan30g wants to merge 1 commit into
Conversation
When setup.py was replaced with pyproject.toml in v7 (TkTech#124) the PyPI classifiers, license, author, keywords and description got left behind, so the license badge in the README shows up as missing because it reads the license classifier from PyPI. This puts the MIT license classifier back along with the rest of the metadata that was there before, so the badge works again and the package page has proper info. Verified by building the sdist and checking that PKG-INFO now carries the "License :: OSI Approved :: MIT License" classifier. Fixes TkTech#131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README license badge (
img.shields.io/pypi/l/pysimdjson) shows up as "missing" because it reads the license from the PyPI Trove classifiers, and those got dropped whensetup.pywas migrated topyproject.tomlin v7 (#124). You already spotted this in the issue.This restores the metadata that was in the old
setup.pybut never carried over:License :: OSI Approved :: MIT Licenseclassifier (the one the badge needs) plus the other classifiersdescriptioninstead of the leftover "Add your description here" placeholderI verified it by building the sdist and checking
PKG-INFO, which now includes:I kept
Development Status :: 3 - Alphato match what was there before, happy to bump it if you'd rather it reflect the current maturity.Fixes #131