Restore package classifiers and metadata lost in pyproject.toml migration - #140
Open
Rehan30g wants to merge 1 commit into
Open
Restore package classifiers and metadata lost in pyproject.toml migration#140Rehan30g wants to merge 1 commit into
Rehan30g wants to merge 1 commit into
Conversation
…tion The switch from setup.py to pyproject.toml in TkTech#124 dropped the classifiers, license, author, and keyword metadata that used to be set in setup.py, including the OSI license classifier that the README's PyPI license badge depends on. Also fixes the leftover 'Add your description here' placeholder description. Closes TkTech#131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131.
The migration from
setup.pytopyproject.tomlin #124 dropped achunk of the project metadata that used to be set in
setup.py:classifiers, license, author, and keywords. This included the
License :: OSI Approved :: MIT Licenseclassifier, which is whatthe PyPI license badge in the README depends on to render (hence the
"license missing???" report). It also left the placeholder
description = "Add your description here"in place.This restores that metadata in
[project]:license,authors,keywords,classifiers(carried over fromthe old
setup.py)description[project.urls]for the homepage and docs, since those were alsopresent in the old
setup.pyviaurl=Verified locally that
pip install -e .andpython -m build --sdistboth produce a
PKG-INFO/egg-infowith the classifiers and licensepopulated correctly, and the full test suite still passes.