Skip to content

fix: Expose the Baidu error if translation is not successful #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Green-Sky merged 1 commit into from
Sep 8, 2026
Merged

fix: Expose the Baidu error if translation is not successful #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 37 additions & 6 deletions tools/translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import multiprocessing
import subprocess # nosec
import textwrap
import time
import xml.dom.minidom as minidom # nosec
from dataclasses import dataclass
from functools import cache as memoize
Expand Down Expand Up @@ -189,8 +190,9 @@ def _baidu_call_translate(lang: Language, text: str) -> str:
E.g. it says that "vimcu lo citri" means "I will eat the lemon" when it
actually means "remove the history".
"""
response = requests.post(
"https://fanyi.baidu.com/ait/text/translate",
response = _request_with_retry(
method="POST",
url="https://fanyi.baidu.com/ait/text/translate",
json={
"domain": "common",
"from": "en",
Expand All @@ -200,7 +202,7 @@ def _baidu_call_translate(lang: Language, text: str) -> str:
},
)
response.raise_for_status()
events = (
events = list(
json.loads(line.removeprefix("data: "))
for line in response.text.split("\n")
if line.startswith("data: ")
Expand All @@ -213,7 +215,35 @@ def _baidu_call_translate(lang: Language, text: str) -> str:
and event["data"]["list"]
for para in event["data"]["list"]
)
return "\n".join(translations)
translations_as_string = "\n".join(translations)
if not translations_as_string:
errors = list(filter(lambda x: bool(x.get("errmsg")), events))
if errors:
raise ValueError(
f'Failed to translate "{text}" to "{lang.baidu_code}" using Baidu. '
f'Response: Error number: {errors[0].get("errno")}; Error message: {errors[0].get("errmsg")}.'
)
return translations_as_string


def _request_with_retry(
method: str,
url: str,
params: dict[str, str] | None = None,
json: dict[str, str] | None = None,
retries: int = 3,
) -> requests.Response:
response = requests.request(method, url, params=params, json=json)
sleep_time = 0.5
for _ in range(retries):
# Handle the service throttling.
if response.status_code == 429:
time.sleep(sleep_time)
sleep_time += 0.5
response = requests.request(method, url, params=params, json=json)
else:
break
return response


def _validate_translation(source: str, translation: str) -> bool:
Expand Down Expand Up @@ -284,8 +314,9 @@ def _translate(lang: Language, current: int, total: int, text: str) -> str:
return ""
if lang.weblate_code in _BAIDU_LANGUAGES:
return _fix_translation(lang, text, _baidu_translate(lang, text))
response = requests.get(
"https://translate.googleapis.com/translate_a/single",
response = _request_with_retry(
method="GET",
url="https://translate.googleapis.com/translate_a/single",
params={
"client": "gtx",
"sl": "en",
Expand Down
Loading