refactor(projects): remove misleading Hub lifecycle status filter (#2274 B-6) - #2323
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semantics (Option A — hard evidence)
Hub Project is a workspace/container; there is NO server-authoritative project lifecycle/status/archive transition. Verified: OpenAPI
WorkspaceProject(required=[id,name,owner_id,created_at,updated_at]; properties id/name/description/owner_id/created_at/updated_at) has no status field; DB workspaces table is 6 columns;GET /web/projectsaccepts only q/pageCursor/pageSize; create/patch bodies only name/description. #2316 (B-6 hygiene) already removed the structurally-unreachablestatus:Activeorphan mapper, fixed the stale comments, and aligned openapi enums; it explicitly DEFFERED the product-visible filter-chips to the operator (ADR-034 convergence path). This PR takes that deferred decision: no server lifecycle → the UI must not present lifecycle filters.Change
Remove the misleading Project lifecycle filter (Running/Completed/Archived chips) from the Workbench Projects left nav — the whole chip bar (incl
All projectswhich only belonged to it). Delete the only-for-this-filter state:projectFilter/availableProjectFilters/filterProjectsByStatus/resolveAvailableProjectFilters/projectStatusBucket/ProjectStatusBucket/PROJECT_STATUS_BUCKETS/FILTER_ITEMSand the nav props/types/export/CSS.visibleProjectsnow derives straight fromsourceProjects(no new predicate). Search, project rows, selection, and loading/error notices are kept; selection/active-fallback behavior unchanged.Not changed
ProjectInfo.statusis NOT renamed/refactored (still the display label; row/head badge still shows it).Verification
git diff --checkPASS.