Skip to content

refactor(projects): remove misleading Hub lifecycle status filter (#2274 B-6) - #2323

Merged
DeliciousBuding merged 1 commit into
masterfrom
fix/project-lifecycle-truth
Sep 5, 2026
Merged

refactor(projects): remove misleading Hub lifecycle status filter (#2274 B-6)#2323
DeliciousBuding merged 1 commit into
masterfrom
fix/project-lifecycle-truth

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

Semantics (Option A — hard evidence)

Hub Project is a workspace/container; there is NO server-authoritative project lifecycle/status/archive transition. Verified: OpenAPI WorkspaceProject (required=[id,name,owner_id,created_at,updated_at]; properties id/name/description/owner_id/created_at/updated_at) has no status field; DB workspaces table is 6 columns; GET /web/projects accepts only q/pageCursor/pageSize; create/patch bodies only name/description. #2316 (B-6 hygiene) already removed the structurally-unreachable status:Active orphan mapper, fixed the stale comments, and aligned openapi enums; it explicitly DEFFERED the product-visible filter-chips to the operator (ADR-034 convergence path). This PR takes that deferred decision: no server lifecycle → the UI must not present lifecycle filters.

Change

Remove the misleading Project lifecycle filter (Running/Completed/Archived chips) from the Workbench Projects left nav — the whole chip bar (incl All projects which only belonged to it). Delete the only-for-this-filter state: projectFilter/availableProjectFilters/filterProjectsByStatus/resolveAvailableProjectFilters/projectStatusBucket/ProjectStatusBucket/PROJECT_STATUS_BUCKETS/FILTER_ITEMS and the nav props/types/export/CSS. visibleProjects now derives straight from sourceProjects (no new predicate). Search, project rows, selection, and loading/error notices are kept; selection/active-fallback behavior unchanged.

Not changed

  • Task status filter, ProjectRun status, web queue status, AgentTeam status — untouched.
  • ProjectInfo.status is NOT renamed/refactored (still the display label; row/head badge still shows it).
  • No backend schema/API/state machine introduced.

Verification

  • focused workbench tests: ProjectNav 1/1, useWorkbenchProjectsRoute 4/4, workbenchRoutesHelpers 9/9, ProjectsPage 11/11 → 25/25.
  • @agenthub/workbench typecheck PASS.
  • canonical coverage baseline @agenthub/workbench: EXIT=0, uncovered 5 (=baseline), zero skipped, no regression.
  • git diff --check PASS.
  • Net 14 files changed (+8/-424 tracked) plus new ProjectNav.test.tsx; 2 obsolete filter tests removed.

 B-6)

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 9e46068e-a4a0-4217-95a9-48e93a64589d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeliciousBuding
DeliciousBuding merged commit 319bebe into master Sep 5, 2026
43 checks passed
@DeliciousBuding
DeliciousBuding deleted the fix/project-lifecycle-truth branch September 5, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant