fix(agent): propagate custom-agent request cancellation - #2330
Merged
Conversation
Bind every custom-agent CRUD database operation to the caller context. Cover canceled mutations and the ownership-read boundary in L0; prove HTTP deadline/disconnect releases blocked PostgreSQL queries and pool capacity before unlock in L1. Refs #2329 Refs #2256 Co-authored-by: Codex <codex@vectorcontrol.tech>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DeliciousBuding
marked this pull request as ready for review
September 6, 2026 04:42
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2329
Refs #2256 (only the custom-agent request-context slice; other candidates remain open).
Evidence
go test ./... -short -count=1) passes. Full PostgreSQL + Redis L1 with-racepasses (33.339 s test runtime); both new cancellation cases also pass under race. Migration 0040 PostgreSQL audit also passes (2 tests). Required CI gates are checked separately before merge.Environment / not claimed
The local Windows CGO compiler probe fails independently of the changed code; CGO=0 cannot run existing go-sqlite3 tests, so it is not accepted as a full-L0 substitute. Linux CGO/race is used instead and Windows CI remains required. An existing integration helper hard-codes localhost:5432, so a temporary loopback relay targets the disposable fixture for the full local L1 suite. No production or development service, credentials, DNS/ACL, runtime configuration, or deployment was changed. Identity in this test is a fixture; no L3/L4 claim.