fix(store): prune run checkpoints and preserve SQLite delta baselines - #2336
Conversation
Fix checkpoint retention after run cleanup or thread deletion and stop rewriting unchanged checkpoint rows. Closes #2335. Co-authored-by: Codex <codex@vectorcontrol.tech>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Final-head review at The two production lines, real SQLite negative/positive regressions and owner-document change were reviewed together. Full local package/Windows/race/static/doc validation and 45 matching-fixture post-fix samples pass. No migration, existing orphan repair or runtime deployment. |
Summary
Closes #2335
Refs #2333 / #2256.
Two production-line fixes at existing ownership boundaries:
No pool/PRAGMA/schema/API/timer changes. Update the Edge owner document for checkpoint lifetime and the actual
finishedterminal run status.Regression evidence
Corrected red output on mainline, followed by green behavior.
Validation
CGO_ENABLED=0): PASS (1.569 s).go vet ./internal/store, staticcheck 2026.1,verify-doc-ssot.py, and diff check pass.Boundaries
Only isolated generated fixtures. No production database, deployment or migration. This prevents future orphan retention through the corrected removal paths; it does not automatically repair checkpoints already orphaned in an existing live store. Any existing-data repair is a separate scope. Allocation/timing comparisons are local workload results, not production guarantees.