feat: split transaction fee into inclusion and resource components#241
Open
shogun444 wants to merge 1 commit into
Open
feat: split transaction fee into inclusion and resource components#241shogun444 wants to merge 1 commit into
shogun444 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements transaction fee breakdown analysis by extracting fee information directly from transaction XDR data.
The fee analyzer now parses TransactionEnvelope, TransactionResult, and TransactionMeta to derive total fee, inclusion fee, resource fee, and bid fee. Soroban resource fees are calculated from refundable, non-refundable, and rent fee components, while non-Soroban transactions fall back safely without errors.
The CLI output has been updated to display the actual bid fee instead of a placeholder value. Unit tests were added to cover both classic and Soroban transactions, and the full test suite passes successfully.
Closes #223