Skip to content

Commit 0ba474e

Browse files
author
DavidQ
committed
No commit; leave PR_073 and PR_074 changes local for review
1 parent 7fed1b7 commit 0ba474e

45 files changed

Lines changed: 215 additions & 181 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/dev/reports/engine_network_index_barrel_removal_report.md‎

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# PR_26140_073 Engine Network Index Barrel Removal
2+
3+
## Scope
4+
- Removed only the targeted `src/engine/network/index.js` barrel.
5+
- Replaced active imports from the network barrel with direct canonical imports.
6+
- Import-only edits were made where required.
7+
- Did not change schemas.
8+
- Did not touch sample JSON.
9+
- Did not remove sample/game entry `index.js` files.
10+
- Did not remove `src/engine/core/index.js`.
11+
- Did not run PR_26140_074 until this PR validated.
12+
13+
## Target Barrel
14+
- Deleted: `src/engine/network/index.js`
15+
16+
## Direct Import Updates
17+
- `samples/phase-13/1301/NetworkingLayerScene.js`
18+
- `samples/phase-13/1302/StateSyncReplicationScene.js`
19+
- `samples/phase-13/1304/ClientPredictionReconciliationScene.js`
20+
- `samples/phase-13/1305/SerializationSystemScene.js`
21+
- `samples/phase-13/1306/NetworkDebugOverlayScene.js`
22+
- `samples/phase-13/1307/RemoteEntityInterpolationScene.js`
23+
- `samples/phase-13/1308/LobbySessionSystemScene.js`
24+
- `samples/phase-13/1310/HostServerBootstrapScene.js`
25+
- `samples/phase-13/1311/InterestManagementScene.js`
26+
- `samples/phase-13/1312/LagPacketLossSimulationScene.js`
27+
- `samples/phase-13/1314/ChatPresenceLayerScene.js`
28+
- `samples/phase-13/1315/RollbackReplayDiagnosticsScene.js`
29+
- `samples/phase-13/1319/server/realNetworkServer.mjs`
30+
- `tests/final/MultiplayerNetworkingStack.test.mjs`
31+
32+
## Validation
33+
- PASS: `node --check` for the 14 PR73 changed JS/MJS files.
34+
- PASS: direct import target validation for the 14 PR73 changed JS/MJS files.
35+
- PASS: no active references to `engine/network/index.js` remain in repo-owned JS/MJS outside reports/results.
36+
- PASS: `src/engine/network/index.js` no longer exists.
37+
- PASS: `node --input-type=module -e "const m = await import('./tests/final/MultiplayerNetworkingStack.test.mjs'); await m.run(); console.log('PASS MultiplayerNetworkingStack');"`
38+
- PASS: `npm run test:workspace-v2`
39+
- 59 passed.
40+
41+
## Not Run
42+
- Full samples smoke test was not run.
43+
44+
## Delta ZIP
45+
- `tmp/PR_26140_073-remove-engine-network-index-barrels_delta.zip`

‎docs/dev/reports/engine_systems_index_barrel_removal_phase1_report.md‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
# PR_26140_074 Engine Systems Index Barrel Removal Phase 1
2+
3+
## Scope
4+
- Removed only the targeted `src/engine/systems/index.js` barrel.
5+
- Replaced active imports from the systems barrel with direct canonical imports.
6+
- Import-only edits were made where required.
7+
- Did not change schemas.
8+
- Did not touch sample JSON.
9+
- Did not remove sample/game entry `index.js` files.
10+
- Did not remove `src/engine/core/index.js`.
11+
- Stopped before core cleanup.
12+
13+
## Target Barrel
14+
- Deleted: `src/engine/systems/index.js`
15+
16+
## Direct Import Updates
17+
- `samples/phase-01/0116/ECSMovementSystemScene.js`
18+
- `samples/phase-01/0117/ECSInputSystemScene.js`
19+
- `samples/phase-01/0118/ECSCollisionSystemScene.js`
20+
- `samples/phase-01/0119/ECSRenderSystemScene.js`
21+
- `samples/phase-01/0120/ECSSceneWorldScene.js`
22+
- `samples/phase-01/0121/UIOverlayScene.js`
23+
- `samples/phase-01/0122/EntityLifecycleScene.js`
24+
- `samples/phase-01/0123/DebugStatsScene.js`
25+
- `samples/phase-01/0124/DataDrivenWorldScene.js`
26+
- `samples/phase-02/0210/ProjectileSystemScene.js`
27+
- `samples/phase-02/0212/PlayableMicroLevelScene.js`
28+
- `samples/phase-02/0218/PolishedPlayableSliceScene.js`
29+
- `samples/phase-02/0225/game/ProjectileLabModel.js`
30+
- `samples/phase-03/0301/RealSpriteRenderingScene.js`
31+
- `samples/phase-03/0302/AnimationSystemScene.js`
32+
- `samples/phase-03/0303/PhysicsSystemScene.js`
33+
- `samples/phase-03/0304/CollisionResolutionScene.js`
34+
- `samples/phase-03/0305/TileMetadataScene.js`
35+
- `samples/phase-03/0306/NESStyleZonesParallaxScene.js`
36+
- `samples/phase-16/1601/CubeExplorer3DScene.js`
37+
- `samples/phase-16/1602/MazeRunner3DScene.js`
38+
- `samples/phase-16/1603/FirstPersonWalkthroughScene.js`
39+
- `samples/phase-16/1604/Platformer3DBasicsScene.js`
40+
- `samples/phase-16/1605/DrivingSandbox3DScene.js`
41+
- `samples/phase-16/1608/DungeonCrawler3DScene.js`
42+
- `tests/core/Engine2DCapabilityCombinedFoundation.test.mjs`
43+
- `tests/core/EngineCoreBoundaryBaseline.test.mjs`
44+
45+
## Validation
46+
- PASS: `node --check` for the 27 PR74 changed JS/MJS files.
47+
- PASS: direct import target validation for the 27 PR74 changed JS/MJS files.
48+
- PASS: no active references to `engine/systems/index.js` remain in repo-owned JS/MJS outside reports/results.
49+
- PASS: `src/engine/systems/index.js` no longer exists.
50+
- PASS: `npm run test:workspace-v2`
51+
- 59 passed.
52+
53+
## Not Run
54+
- Full samples smoke test was not run.
55+
56+
## Delta ZIP
57+
- `tmp/PR_26140_074-remove-engine-systems-index-barrels-phase1_delta.zip`

‎samples/phase-01/0116/ECSMovementSystemScene.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
1010
import World from '/src/engine/ecs/World.js';
1111
import { createTransform, createSize, createVelocity, createRenderable } from '/src/engine/components/index.js';
1212
import { drawSceneFrame } from '/src/engine/debug/DebugPanel.js';
13-
import { moveEntities, bounceEntitiesHorizontallyInBounds, renderRectEntities } from '/src/engine/systems/index.js';
13+
import { moveEntities } from '/src/engine/systems/MovementSystem.js';
14+
import { bounceEntitiesHorizontallyInBounds } from '/src/engine/systems/BounceSystem.js';
15+
import { renderRectEntities } from '/src/engine/systems/RenderSystem.js';
1416

1517
const theme = new Theme(ThemeTokens);
1618

‎samples/phase-01/0117/ECSInputSystemScene.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ import {
1717
createRenderable,
1818
} from '/src/engine/components/index.js';
1919
import { drawSceneFrame } from '/src/engine/debug/DebugPanel.js';
20-
import { applyInputControl, moveEntities, clampEntitiesToBounds, renderRectEntities } from '/src/engine/systems/index.js';
20+
import { applyInputControl } from '/src/engine/systems/InputControlSystem.js';
21+
import { moveEntities } from '/src/engine/systems/MovementSystem.js';
22+
import { clampEntitiesToBounds } from '/src/engine/systems/BoundsSystem.js';
23+
import { renderRectEntities } from '/src/engine/systems/RenderSystem.js';
2124

2225
const theme = new Theme(ThemeTokens);
2326

‎samples/phase-01/0118/ECSCollisionSystemScene.js‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,10 @@ import {
1919
createRenderable,
2020
} from '/src/engine/components/index.js';
2121
import { drawSceneFrame } from '/src/engine/debug/DebugPanel.js';
22-
import {
23-
applyInputControl,
24-
moveEntities,
25-
blockCollidingEntities,
26-
renderRectEntities,
27-
} from '/src/engine/systems/index.js';
22+
import { applyInputControl } from '/src/engine/systems/InputControlSystem.js';
23+
import { moveEntities } from '/src/engine/systems/MovementSystem.js';
24+
import { blockCollidingEntities } from '/src/engine/systems/CollisionSystem.js';
25+
import { renderRectEntities } from '/src/engine/systems/RenderSystem.js';
2826

2927
const theme = new Theme(ThemeTokens);
3028

‎samples/phase-01/0119/ECSRenderSystemScene.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
1010
import World from '/src/engine/ecs/World.js';
1111
import { drawSceneFrame } from '/src/engine/debug/DebugPanel.js';
12-
import { renderRectEntities } from '/src/engine/systems/index.js';
12+
import { renderRectEntities } from '/src/engine/systems/RenderSystem.js';
1313

1414
const theme = new Theme(ThemeTokens);
1515

‎samples/phase-01/0120/ECSSceneWorldScene.js‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,10 @@ import {
2020
} from '/src/engine/components/index.js';
2121
import { drawSceneFrame } from '/src/engine/debug/DebugPanel.js';
2222
import { drawValidationPanel, validateWorldEntities } from '/src/engine/debug/Validation.js';
23-
import {
24-
applyInputControl,
25-
moveEntities,
26-
blockCollidingEntities,
27-
renderRectEntities,
28-
} from '/src/engine/systems/index.js';
23+
import { applyInputControl } from '/src/engine/systems/InputControlSystem.js';
24+
import { moveEntities } from '/src/engine/systems/MovementSystem.js';
25+
import { blockCollidingEntities } from '/src/engine/systems/CollisionSystem.js';
26+
import { renderRectEntities } from '/src/engine/systems/RenderSystem.js';
2927

3028
const theme = new Theme(ThemeTokens);
3129

‎samples/phase-01/0121/UIOverlayScene.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@ import {
1717
createRenderable,
1818
} from '/src/engine/components/index.js';
1919
import { drawSceneFrame, drawPanel } from '/src/engine/debug/DebugPanel.js';
20-
import {
21-
applyInputControl,
22-
moveEntities,
23-
renderRectEntities,
24-
} from '/src/engine/systems/index.js';
20+
import { applyInputControl } from '/src/engine/systems/InputControlSystem.js';
21+
import { moveEntities } from '/src/engine/systems/MovementSystem.js';
22+
import { renderRectEntities } from '/src/engine/systems/RenderSystem.js';
2523

2624
const theme = new Theme(ThemeTokens);
2725

‎samples/phase-01/0122/EntityLifecycleScene.js‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ import {
1919
createTag,
2020
} from '/src/engine/components/index.js';
2121
import { drawSceneFrame, drawPanel } from '/src/engine/debug/DebugPanel.js';
22-
import {
23-
applyInputControl,
24-
moveEntities,
25-
renderRectEntities,
26-
tickLifetimes,
27-
collectOverlappingEntities,
28-
} from '/src/engine/systems/index.js';
22+
import { applyInputControl } from '/src/engine/systems/InputControlSystem.js';
23+
import { moveEntities } from '/src/engine/systems/MovementSystem.js';
24+
import { renderRectEntities } from '/src/engine/systems/RenderSystem.js';
25+
import { tickLifetimes } from '/src/engine/systems/LifecycleSystem.js';
26+
import { collectOverlappingEntities } from '/src/engine/systems/CollectSystem.js';
2927

3028
const theme = new Theme(ThemeTokens);
3129

‎samples/phase-01/0123/DebugStatsScene.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@ import {
1616
} from '/src/engine/components/index.js';
1717
import { drawSceneFrame, drawPanel } from '/src/engine/debug/DebugPanel.js';
1818
import StatsTracker from '/src/engine/debug/StatsTracker.js';
19-
import {
20-
moveEntities,
21-
bounceEntitiesHorizontallyInBounds,
22-
renderRectEntities,
23-
} from '/src/engine/systems/index.js';
19+
import { moveEntities } from '/src/engine/systems/MovementSystem.js';
20+
import { bounceEntitiesHorizontallyInBounds } from '/src/engine/systems/BounceSystem.js';
21+
import { renderRectEntities } from '/src/engine/systems/RenderSystem.js';
2422

2523
const theme = new Theme(ThemeTokens);
2624

0 commit comments

Comments
 (0)