Remove remaining engine systems index barrel exports - PR_26140_075-remove-engine-systems-index-barrels-phase2, and Remove engine core index barrel exports - PR_26140_076-remove-engine-core-index-barrel

Author: DavidQ

docs/dev/reports/engine_core_index_barrel_removal_report.md

@@ -0,0 +1,47 @@
+# PR_26140_076 Engine Core Index Barrel Removal
+
+## Scope
+- Removed `src/engine/core/index.js` barrel usage.
+- Replaced active imports from `src/engine/core/index.js` with direct canonical imports.
+- Deleted `src/engine/core/index.js` after no active imports remained.
+- Import-only/direct-reference edits were limited to affected core tests.
+- Did not change schemas.
+- Did not touch sample JSON.
+- Did not remove sample/game entry `index.js` files.
+- Did not create replacement pass-through files.
+- Did not move runtime logic or circular dependency logic.
+
+## Target Barrel
+- Deleted: `src/engine/core/index.js`
+
+## Direct Import Updates
+- `tests/core/Engine2DCapabilityCombinedFoundation.test.mjs`
+  - `Engine` now imports directly from `src/engine/core/Engine.js`.
+- `tests/core/EngineCoreBoundaryBaseline.test.mjs`
+  - Core namespace import was replaced with direct canonical imports:
+    - `Engine`
+    - `FrameClock`
+    - `FixedTicker`
+    - `RuntimeMetrics`
+    - `EventBus`
+    - `Camera2D`
+    - `Camera3D`
+    - `followCameraTarget`
+    - `worldRectToScreen`
+  - Existing direct imports in the same test are referenced directly so the test remains executable without the removed namespace barrel.
+
+## Validation
+- PASS: `node --check` for the 2 PR76 changed JS/MJS files.
+- PASS: direct import target validation for the 2 PR76 changed JS/MJS files.
+- PASS: no active references to `engine/core/index.js` remain in repo-owned JS/MJS outside reports/results.
+- PASS: `src/engine/core/index.js` no longer exists.
+- PASS: `node --input-type=module -e "const m = await import('./tests/core/EngineCoreBoundaryBaseline.test.mjs'); await m.run(); console.log('PASS EngineCoreBoundaryBaseline');"`
+- PASS: `node --input-type=module -e "const m = await import('./tests/core/Engine2DCapabilityCombinedFoundation.test.mjs'); await m.run(); console.log('PASS Engine2DCapabilityCombinedFoundation');"`
+- PASS: `npm run test:workspace-v2`
+  - 59 passed.
+
+## Not Run
+- Full samples smoke test was not run.
+
+## Delta ZIP
+- `tmp/PR_26140_076-remove-engine-core-index-barrel_delta.zip`

docs/dev/reports/engine_systems_index_barrel_removal_phase2_report.md

@@ -0,0 +1,38 @@
+# PR_26140_075 Engine Systems Index Barrel Removal Phase 2
+
+## Scope
+- Continued after PR_26140_074.
+- Checked for remaining active imports from `src/engine/systems/index.js`.
+- Confirmed `src/engine/systems/index.js` no longer exists.
+- No additional source import edits were required in this PR.
+- Did not change schemas.
+- Did not touch sample JSON.
+- Did not remove sample/game entry `index.js` files.
+- Did not remove `src/engine/core/index.js`.
+- Did not create replacement pass-through files.
+
+## Result
+The remaining systems index barrel cleanup was already complete in the current baseline:
+
+- No active repo-owned JS/MJS imports reference `engine/systems/index.js`.
+- `src/engine/systems/index.js` is absent.
+- No behavior changes were made.
+
+## Validation
+- PASS: `node --check` over changed JS/MJS files.
+  - Result: 0 changed JS/MJS files for PR_26140_075.
+- PASS: direct import target validation over changed JS/MJS files.
+  - Result: 0 changed JS/MJS files for PR_26140_075.
+- PASS: no active references to `engine/systems/index.js` remain in repo-owned JS/MJS outside reports/results.
+- PASS: `src/engine/systems/index.js` no longer exists.
+- PASS: `npm run test:workspace-v2`
+  - 59 passed.
+
+## Affected Systems Tests
+- No affected systems tests were identified by import validation because PR_26140_075 made no source import changes.
+
+## Not Run
+- Full samples smoke test was not run.
+
+## Delta ZIP
+- `tmp/PR_26140_075-remove-engine-systems-index-barrels-phase2_delta.zip`

src/engine/core/index.js

@@ -5,7 +5,7 @@ David Quesenberry
 Engine2DCapabilityCombinedFoundation.test.mjs
 */
 import assert from 'node:assert/strict';
-import { Engine } from '../../src/engine/core/index.js';
+import Engine from '../../src/engine/core/Engine.js';
 import Scene from '../../src/engine/scene/Scene.js';
 import Camera2D from '../../src/engine/camera/Camera2D.js';
 import { followCameraTarget, worldRectToScreen } from '../../src/engine/camera/CameraSystem.js';

tests/core/Engine2DCapabilityCombinedFoundation.test.mjs

@@ -5,7 +5,14 @@ David Quesenberry
 EngineCoreBoundaryBaseline.test.mjs
 */
 import assert from 'node:assert/strict';
-import * as core from '../../src/engine/core/index.js';
+import Engine from '../../src/engine/core/Engine.js';
+import FrameClock from '../../src/engine/core/FrameClock.js';
+import FixedTicker from '../../src/engine/core/FixedTicker.js';
+import RuntimeMetrics from '../../src/engine/core/RuntimeMetrics.js';
+import EventBus from '../../src/engine/events/EventBus.js';
+import Camera2D from '../../src/engine/camera/Camera2D.js';
+import Camera3D from '../../src/engine/camera/Camera3D.js';
+import { followCameraTarget, worldRectToScreen } from '../../src/engine/camera/CameraSystem.js';
 import Scene from '../../src/engine/scene/Scene.js';
 import SceneManager from '../../src/engine/scene/SceneManager.js';
 import CanvasRenderer from '../../src/engine/rendering/CanvasRenderer.js';
@@ -23,51 +30,51 @@ import { stepWorldPhysics3D } from '../../src/engine/systems/PhysicsSystem.js';
 
 export function run() {
   // Core boot/timing boundaries.
-  assert.equal(typeof core.Engine, 'function');
-  assert.equal(typeof core.FrameClock, 'function');
-  assert.equal(typeof core.FixedTicker, 'function');
-  assert.equal(typeof core.RuntimeMetrics, 'function');
+  assert.equal(typeof Engine, 'function');
+  assert.equal(typeof FrameClock, 'function');
+  assert.equal(typeof FixedTicker, 'function');
+  assert.equal(typeof RuntimeMetrics, 'function');
 
   // Scene/render/input/physics/audio/systems public homes.
-  assert.equal(typeof scene.Scene, 'function');
-  assert.equal(typeof scene.SceneManager, 'function');
-  assert.equal(typeof rendering.CanvasRenderer, 'function');
-  assert.equal(typeof rendering.renderByLayers, 'function');
+  assert.equal(typeof Scene, 'function');
+  assert.equal(typeof SceneManager, 'function');
+  assert.equal(typeof CanvasRenderer, 'function');
+  assert.equal(typeof renderByLayers, 'function');
   assert.equal(typeof InputService, 'function');
   assert.equal(typeof ActionInputService, 'function');
-  assert.equal(typeof physics.stepArcadeBody, 'function');
-  assert.equal(typeof physics.applyDrag, 'function');
-  assert.equal(typeof physics.integrateVelocity3D, 'function');
-  assert.equal(typeof physics.isAabbColliding3D, 'function');
-  assert.equal(typeof physics.resolveAabbCollision3D, 'function');
-  assert.equal(typeof physics.stepSceneBodies3D, 'function');
+  assert.equal(typeof stepArcadeBody, 'function');
+  assert.equal(typeof applyDrag, 'function');
+  assert.equal(typeof integrateVelocity3D, 'function');
+  assert.equal(typeof isAabbColliding3D, 'function');
+  assert.equal(typeof resolveAabbCollision3D, 'function');
+  assert.equal(typeof stepSceneBodies3D, 'function');
   assert.equal(typeof AudioService, 'function');
   assert.equal(typeof moveEntities, 'function');
   assert.equal(typeof moveEntities3D, 'function');
   assert.equal(typeof stepArcadeBody, 'function');
   assert.equal(typeof stepWorldPhysics3D, 'function');
 
   // Combined service cluster contracts: timing/frame, event routing, camera.
-  const frameClock = new core.FrameClock({ now: () => 100, maxDeltaMs: 100 });
+  const frameClock = new FrameClock({ now: () => 100, maxDeltaMs: 100 });
   frameClock.reset(100);
   const tick = frameClock.tick(116);
   assert.equal(tick.deltaMs, 16);
 
-  const ticker = new core.FixedTicker({ stepMs: 10, maxCatchUpSteps: 5 });
+  const ticker = new FixedTicker({ stepMs: 10, maxCatchUpSteps: 5 });
   const steps = [];
   const tickerResult = ticker.advance(25, (stepSeconds) => steps.push(stepSeconds));
   assert.equal(tickerResult.steps, 2);
   assert.deepEqual(steps, [0.01, 0.01]);
 
-  const bus = new core.EventBus();
+  const bus = new EventBus();
   let eventSeen = 0;
   bus.on('engine.core.boundary', () => {
     eventSeen += 1;
   });
   assert.equal(bus.emit('engine.core.boundary', { ok: true }), 1);
   assert.equal(eventSeen, 1);
 
-  const camera = new core.Camera2D({
+  const camera = new Camera2D({
     x: 0,
     y: 0,
     viewportWidth: 100,
@@ -76,14 +83,14 @@ export function run() {
     worldHeight: 300,
   });
   const target = { x: 80, y: 50, width: 20, height: 20 };
-  core.followCameraTarget(camera, target, true);
-  const rect = core.worldRectToScreen(camera, { x: 100, y: 100, width: 10, height: 10 });
+  followCameraTarget(camera, target, true);
+  const rect = worldRectToScreen(camera, { x: 100, y: 100, width: 10, height: 10 });
   assert.equal(typeof rect.x, 'number');
   assert.equal(typeof rect.y, 'number');
   assert.equal(rect.width, 10);
   assert.equal(rect.height, 10);
 
-  const camera3D = new core.Camera3D({
+  const camera3D = new Camera3D({
     position: { x: 1, y: 2, z: 3 },
     rotation: { x: 0.1, y: 0.2, z: 0.3 },
   });
@@ -117,11 +124,11 @@ export function run() {
     depth: 2,
   };
 
-  physics.integrateVelocity3D(movingBody, 0.5);
+  integrateVelocity3D(movingBody, 0.5);
   assert.equal(movingBody.x, 3);
-  assert.equal(physics.isAabbColliding3D(movingBody, wallBody), true);
+  assert.equal(isAabbColliding3D(movingBody, wallBody), true);
 
-  const resolveResult = physics.resolveAabbCollision3D(movingBody, wallBody);
+  const resolveResult = resolveAabbCollision3D(movingBody, wallBody);
   assert.equal(resolveResult.collided, true);
   assert.equal(resolveResult.axis, 'x');
   assert.equal(movingBody.x, 2);
@@ -143,7 +150,7 @@ export function run() {
     ],
     staticColliders3D: [],
   };
-  const stepSummary = physics.stepSceneBodies3D(scene3D, 0.5);
+  const stepSummary = stepSceneBodies3D(scene3D, 0.5);
   assert.equal(stepSummary.movedBodies, 1);
   assert.equal(stepSummary.resolvedCollisions, 0);
   assert.equal(scene3D.bodies3D[0].x, 1);
@@ -152,7 +159,7 @@ export function run() {
   const before3D = world3D.getComponent(movingEntity, 'transform3D');
   assert.equal(before3D.x, 0);
   assert.equal(before3D.z, 8);
-  const physics3DSummary = systems.stepWorldPhysics3D(world3D, 1);
+  const physics3DSummary = stepWorldPhysics3D(world3D, 1);
   const after3D = world3D.getComponent(movingEntity, 'transform3D');
   const velocity3D = world3D.getComponent(movingEntity, 'velocity3D');
   assert.equal(physics3DSummary.movedEntities, 1);