Skip to content

Commit c2fa7a8

Browse files
author
DavidQ
committed
Remove 2 additional unused tool-specific JSON files verified by audit - PR 11.51
1 parent 9eaf0b9 commit c2fa7a8

7 files changed

Lines changed: 106 additions & 5 deletions

docs/dev/codex_commands.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
# Codex Commands PR 11.50
1+
# Codex Commands - PR 11.51
22

33
Model: GPT-5.4
4-
Reasoning: high
4+
Reasoning: medium
55

66
```powershell
7-
cd C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming
8-
codex --model gpt-5.4 --reasoning high "Run PR 11.50 from docs/pr/PR_11_50_CONTROLLED_JSON_CLEANUP.md. Execute the audit script, choose exactly two safe tool-specific NO JSON files, verify manually, remove only confirmed dead JSON files, capture before/after audit reports under docs/dev/reports, run targeted validation only, and create the final repo ZIP at tmp/PR_11_50_CONTROLLED_JSON_CLEANUP.zip. Do not touch palette.json, tile-map-editor-document.json, sample 1902, roadmap text, shared loaders, or framework code."
7+
codex --model gpt-5.4 --reasoning medium "Run PR 11.51 controlled JSON cleanup. Follow docs/pr/PR_11_51_CONTROLLED_JSON_CLEANUP.md exactly. Run the audit script, select exactly two safe tool-specific NO JSON files, manually validate direct and broader references, remove only proven unused files, update docs/dev/reports/PR_11_51_audit_report.md with before/after counts and validation evidence, update only roadmap status markers if execution-backed, and package the final repo-structured artifact at tmp/PR_11_51_CONTROLLED_JSON_CLEANUP.zip. Do not run the full sample suite unless shared loader/framework files are changed."
98
```

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Remove two verified NO sample JSON payloads in controlled cleanup (1208) with targeted validation and audit delta - PR 11.50
1+
Remove 2 additional unused tool-specific JSON files verified by audit - PR 11.51
19.7 KB
Binary file not shown.
19.7 KB
Binary file not shown.
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
# PR 11.51 Audit Report
2+
3+
## Scope Followed
4+
- Ran `scripts/PS/audit-sample-json-js-references.ps1`.
5+
- Selected exactly two tool-specific `NO` candidates for manual validation.
6+
- Performed direct JS and broader reference checks.
7+
- Applied cleanup only if proven unused.
8+
9+
## Before Audit
10+
Source: `docs/dev/reports/PR_11_51_audit_before.txt`
11+
12+
```text
13+
YES count: 39
14+
NO count: 55
15+
TOTAL count: 94
16+
```
17+
18+
## Candidate Validation
19+
Candidate 1:
20+
- Path: `samples/phase-05/0512/sample.0512.performance-profiler.json`
21+
- Direct JS reference check:
22+
- `rg -n --fixed-strings "sample.0512.performance-profiler.json" . --glob "samples/**/*.js"`
23+
- Result: no matches
24+
- Broader repo reference check (excluding docs/tmp):
25+
- `rg -n --fixed-strings "sample.0512.performance-profiler.json" . --glob "!docs/**" --glob "!tmp/**" --glob "!.git/**"`
26+
- Result: `samples/metadata/samples.index.metadata.json:4440` (`roundtripToolPresets[].presetPath`)
27+
- Decision: KEPT (blocked; manifest-used indirectly)
28+
29+
Candidate 2:
30+
- Path: `samples/phase-07/0708/sample.0708.replay-visualizer.json`
31+
- Direct JS reference check:
32+
- `rg -n --fixed-strings "sample.0708.replay-visualizer.json" . --glob "samples/**/*.js"`
33+
- Result: no matches
34+
- Broader repo reference check (excluding docs/tmp):
35+
- `rg -n --fixed-strings "sample.0708.replay-visualizer.json" . --glob "!docs/**" --glob "!tmp/**" --glob "!.git/**"`
36+
- Result: `samples/metadata/samples.index.metadata.json:5262` (`roundtripToolPresets[].presetPath`)
37+
- Decision: KEPT (blocked; manifest-used indirectly)
38+
39+
## Safety Gate Outcome
40+
- Non-blocked `NO` candidates after exclusions (`palette`, `tile-map-editor-document`, `sample 1902`, metadata file): `31`
41+
- Of those `31`, candidates present in live `roundtripToolPresets`: `31`
42+
- Safe removable candidates found under PR 11.51 rules: `0`
43+
44+
Because every eligible `NO` candidate is still wired through live sample metadata, no file was proven unused after broader validation. No deletions were applied.
45+
46+
## After Audit
47+
Source: `docs/dev/reports/PR_11_51_audit_after.txt`
48+
49+
```text
50+
YES count: 39
51+
NO count: 55
52+
TOTAL count: 94
53+
```
54+
55+
## Full Suite Decision
56+
Full samples smoke test: SKIPPED
57+
Reason: no code or JSON removals were applied; shared loader/framework files were not modified.
38.4 KB
Binary file not shown.
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# PR 11.51 - Controlled JSON Cleanup
2+
3+
## Purpose
4+
Continue the audit-driven sample JSON cleanup lane with the smallest safe executable change.
5+
6+
## Scope
7+
- Run `scripts/PS/audit-sample-json-js-references.ps1`.
8+
- Select exactly 2 `NO` JSON items from safe tool-specific cleanup targets.
9+
- Manually validate both files before removal.
10+
- Remove only files proven unused by direct and broader reference checks.
11+
- Do not touch shared, palette, tile-map-editor, sample 1902, roadmap text, or framework files.
12+
13+
## Required Selection Rules
14+
Allowed candidates:
15+
- tool-specific JSON only
16+
- profiler, replay, pipeline, 3D tools, or equivalent isolated tool payloads
17+
- currently reported as `NO` by the audit script
18+
- no direct JS reference
19+
- no broader repo reference except audit output/report text
20+
21+
Blocked candidates:
22+
- `palette.json`
23+
- `tile-map-editor-document.json`
24+
- anything under sample 1902
25+
- shared loader/framework files
26+
- manifests used indirectly
27+
- uncertain candidates
28+
29+
## Validation Commands
30+
```powershell
31+
.\scripts\PS\audit-sample-json-js-references.ps1
32+
33+
# For each candidate filename:
34+
Select-String -Path .\samples\**\*.js -Pattern "<filename>"
35+
Select-String -Path .\* -Recurse -Pattern "<filename>"
36+
```
37+
38+
## Apply Rule
39+
If either candidate has uncertainty, keep it and choose another safe `NO` item.
40+
41+
## Acceptance
42+
- Exactly 2 safe unused JSON files removed.
43+
- Audit `NO count` is reduced by 2 or evidence explains why a candidate was kept.
44+
- Targeted validation completed.
45+
- Full samples smoke test skipped unless shared loader/framework files were modified.

0 commit comments

Comments
 (0)