Conversation
Drogon is dropped METHOD_LIST_BEGIN if its not listed in main
1 task
…the-architectural-patterns-of-the-inner-circle-items-api-repository # Conflicts: # CMakeLists.txt # src/controllers/app-controller.cpp # src/controllers/app-controller.h
aasheptunov
reviewed
Mar 27, 2026
|
|
||
| void getToDos (const HttpRequestPtr& req, std::function<void(const HttpResponsePtr&)>&& callback); | ||
| void addToDo (const HttpRequestPtr& req, std::function<void(const HttpResponsePtr&)>&& callback); | ||
| void completeToDos(const HttpRequestPtr& req, std::function<void(const HttpResponsePtr&)>&& callback); |
Collaborator
There was a problem hiding this comment.
Missing space after completeToDos.
Collaborator
Author
There was a problem hiding this comment.
the autoformatter removed them altogether
Comment on lines
+1
to
+6
| #pragma once | ||
| #include <cstdint> | ||
|
|
||
| struct CreateToDoResponse { | ||
| uint64_t id; | ||
| }; No newline at end of file |
Collaborator
There was a problem hiding this comment.
It seems uint64_t is used from stdint.h, not cstdint. I suggest using std::uint64_t.
| for (const auto& t : *todos) | ||
| { | ||
| ToDoDTO dto; | ||
| dto.id = static_cast<int>(t.id()); |
Collaborator
There was a problem hiding this comment.
Can we use uint64_t here?
| { | ||
| Json::Value json; | ||
| json["id"] = id; | ||
| json["id"] = id; |
Collaborator
There was a problem hiding this comment.
There seems to be an extra space here.
Collaborator
Author
There was a problem hiding this comment.
the autoformatter removed them altogether
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55