Skip to content

๐Ÿ› [Fix] ์ด์ˆ˜ ๊ณผ๋ชฉ์„ ๊ณผ๋ชฉ๋ช…์œผ๋กœ ์ถ”๊ฐ€ํ•  ๋•Œ ๋™๋ช… ๊ณผ๋ชฉ์ด๋ฉด ์„œ๋ฒ„ ์˜ค๋ฅ˜#60

Merged
ThreeeJ merged 1 commit into
developfrom
fix/59
Jun 4, 2026

Conversation

@ThreeeJ

@ThreeeJ ThreeeJ commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

โœจ PR ์œ ํ˜•

Fix

๐Ÿ› ๏ธ ์ž‘์—… ๋‚ด์šฉ

์นดํƒˆ๋กœ๊ทธ์— ๋™๋ช… ๊ณผ๋ชฉ์ด ์—ฌ๋Ÿฌ ๊ฑด ์žˆ์„ ๋•Œ ์ด์ˆ˜ ๊ณผ๋ชฉ์„ ๊ณผ๋ชฉ๋ช…์œผ๋กœ ์ถ”๊ฐ€ํ•˜๋ฉด ์„œ๋ฒ„ ์˜ค๋ฅ˜(500)๊ฐ€ ๋ฐœ์ƒํ•˜๋˜ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

  • ์›์ธ: SubjectRepository.findByName ์ด ๋‹จ๊ฑด ๋ฐ˜ํ™˜์„ ๊ธฐ๋Œ€ํ•˜๋Š”๋ฐ, ๋™๋ช… ๊ณผ๋ชฉ์ด 2๊ฑด ์ด์ƒ์ด๋ฉด NonUniqueResultException ์ด ๋ฐœ์ƒํ•ด 500 ์œผ๋กœ ๋–จ์–ด์ง
  • ์กฐ์น˜: findByName โ†’ findFirstByNameOrderByIdAsc ๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ๋™๋ช… ๊ณผ๋ชฉ ์ค‘ id ์˜ค๋ฆ„์ฐจ์ˆœ ์ฒซ ๋ฒˆ์งธ ๊ณผ๋ชฉ์„ ์„ ํƒํ•˜๋„๋ก ์ˆ˜์ •
  • ๋™๋ช… ๊ณผ๋ชฉ ์ผ€์ด์Šค์— ๋Œ€ํ•œ ๋‹จ์œ„ ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€

๐Ÿ“‹ ์ถ”ํ›„ ์ง„ํ–‰ ์ƒํ™ฉ

  • "์ฒซ ๋ฒˆ์งธ ๊ณผ๋ชฉ ์„ ํƒ"์€ 500 ์„ ๋ง‰๊ธฐ ์œ„ํ•œ ์ž„์‹œ ๋ฐฉํŽธ์ž…๋‹ˆ๋‹ค. ๋™๋ช… ๊ณผ๋ชฉ์€ codeยทsemester ๊ฐ€ ๋‹ค๋ฅธ ์‚ฌ์‹ค์ƒ ๋ณ„๊ฐœ ๊ณผ๋ชฉ์ด๋ฏ€๋กœ, ํ–ฅํ›„ code ๋ณ‘๊ธฐ ๋“ฑ์œผ๋กœ ์ •ํ™•ํžˆ ์‹๋ณ„ํ•˜๋Š” ๋ฐฉ์‹ ๊ฒ€ํ†  ํ•„์š”

๐Ÿ“Œ ๋ฆฌ๋ทฐ ํฌ์ธํŠธ

  • findFirstByNameOrderByIdAsc ํŒŒ์ƒ ์ฟผ๋ฆฌ๋กœ ๋™๋ช… ๊ณผ๋ชฉ ์‹œ LIMIT 1 ๋‹จ๊ฑด ๋ณด์žฅ์ด ์˜๋„๋Œ€๋กœ ๋™์ž‘ํ•˜๋Š”์ง€
  • ๊ธฐ์กด ๋ถ„๊ธฐ(๊ณผ๋ชฉ ์—†์Œ 422 / ์ค‘๋ณต ์ด์ˆ˜ 409)๊ฐ€ ๊ทธ๋Œ€๋กœ ์œ ์ง€๋˜๋Š”์ง€

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ

Closes #59

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ./gradlew spotlessApply ๋กœ ํฌ๋งคํŒ… ์ ์šฉ
  • ./gradlew spotlessCheck ํ†ต๊ณผ
  • ./gradlew checkstyleMain checkstyleTest ํ†ต๊ณผ
  • ./gradlew build ์„ฑ๊ณต
  • ./gradlew test ๋ชจ๋“  ํ…Œ์ŠคํŠธ ํ†ต๊ณผ
  • ๊ด€๋ จ ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ / ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€ ์ปจ๋ฒค์…˜ ํ™•์ธ

@ThreeeJ ThreeeJ requested a review from jwon0523 June 4, 2026 06:03
@ThreeeJ ThreeeJ self-assigned this Jun 4, 2026
@ThreeeJ ThreeeJ added the bug Something isn't working label Jun 4, 2026
@ThreeeJ ThreeeJ merged commit 5843416 into develop Jun 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

2 participants