This repository was archived by the owner on Sep 28, 2026. It is now read-only.
Repository navigation
Fix OCI instance PV encryption create contract - #68
Merged
Merged
Conversation
Empty-state instance create failed because launch_options expressed PV encryption without NetworkType. Use the top-level create argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launch_optionsblock that caused fresh instance creation to fail with the pinned OCI providerRoot cause
A real empty-state clean-room apply reached OCI instance creation and failed because the instance request included LaunchOptions without NetworkType. The repository had used
launch_optionssolely to express PV encryption.Validation
Implementation/review validation actually run (static; no live OCI):
./tests/unit/test_terraform_pv_encryption_contract.shpassed./tools/check-agent-safetypassed./tests/unit/test_agent_safety.shpassed./tools/check-sensitive-metadatapassed./tests/unit/test_sensitive_metadata_contract.shpassed./tools/validate-safepassed (ShellCheck SKIP: not installed locally)terraformbinary not installed); CI remains theterraform init -backend=false/terraform validatepathIndependent PRE-COMMIT review of the exact staged diff:
Live acceptance
The renewed clean-room apply has not yet been performed. Live validation resumes only after this fix is merged and main CI is green.