Skip to content
This repository was archived by the owner on Sep 28, 2026. It is now read-only.

fix: ignore comment-only placeholder markers - #70

Merged
bxvtr merged 1 commit into
mainfrom
fix/clean-room-placeholder-detection
Aug 18, 2026
Merged

bxvtr merged 1 commit into
mainfrom
fix/clean-room-placeholder-detection

Conversation

@bxvtr

@bxvtr bxvtr commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Fresh clean-room acceptance stopped before Terraform mutation because a populated terraform.tfvars still matched the committed example comment containing sed -e 's/<.*$//'.
  • The shared detector now treats only active non-comment lines as unresolved placeholders; check-cloud-shell-readiness uses the same helper.
  • Active placeholders such as oci_region = "<oci-region>" remain rejected. Regression coverage covers HCL/YAML rejection and comment-only acceptance.

Test plan

  • Unit contracts for placeholder detection
  • Required PR CI on the new head
  • Live operator acceptance is not part of this change; no infrastructure was mutated during implementation or review.

Treat only active non-comment lines as unresolved angle-bracket
placeholders so copied example documentation no longer blocks deploy.
@bxvtr bxvtr self-assigned this Aug 18, 2026
@bxvtr
bxvtr merged commit 1462b97 into main Aug 18, 2026
5 checks passed
@bxvtr
bxvtr deleted the fix/clean-room-placeholder-detection branch August 18, 2026 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant