Skip to content

chore(bus): cover serial queue processing#359

Open
yordis wants to merge 1 commit into
masterfrom
yordis/chore-queue-serial-processing-tests
Open

chore(bus): cover serial queue processing#359
yordis wants to merge 1 commit into
masterfrom
yordis/chore-queue-serial-processing-tests

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented May 14, 2026

  • Queue dispatch safety needs a regression signal for handlers that own mutable state.
  • Scheduling cleanup is easier to review when the serial processing contract is covered directly.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 14, 2026

PR Summary

Low Risk
Low risk: adds an isolated xUnit test only, with no production code changes; potential flakiness is limited to timing-based async waits.

Overview
Adds a new xUnit test QueuedHandlerThreadPoolTests.processes_messages_serially that publishes multiple messages to QueuedHandlerThreadPool and asserts they are handled one at a time (max concurrency = 1) and that all messages are processed.

The test uses a RecordingConsumer with a small async delay to detect concurrent execution and includes explicit queue start/stop with timeouts to act as a regression signal for the queue’s serial dispatch contract.

Reviewed by Cursor Bugbot for commit 8890826. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Warning

Rate limit exceeded

@yordis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 28 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 59ef67e5-dd9a-4b1a-8167-9179f3a218be

📥 Commits

Reviewing files that changed from the base of the PR and between 3860089 and 8890826.

📒 Files selected for processing (1)
  • src/EventStore.Core.XUnit.Tests/Bus/QueuedHandlerThreadPoolTests.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-queue-serial-processing-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant