feat: bump otel-collector to 0.151.0#29
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
WalkthroughThe OpenTelemetry Collector Contrib Homebrew formula is updated from version 0.147.0 to 0.151.0, with corresponding changes to the download URL and SHA256 hash to match the new upstream release. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
Formula/otel-collector.rb (2)
13-19: Service config/log paths look consistent, but consider ensuring log dir exists.You set
log_path var/"log/otelcol-contrib.log"anderror_log_path var/"log/otelcol-contrib.err.log". Thepost_installcurrently only createsetc/"otelcol-contrib". Ifvar/"log"isn’t created elsewhere by Homebrew services, first-run logging could fail.Consider adding
var/"log"creation inpost_install(or confirming it’s handled automatically in your environment).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Formula/otel-collector.rb` around lines 13 - 19, The service config sets log_path and error_log_path to var/"log/otelcol-contrib.log" and var/"log/otelcol-contrib.err.log" but post_install only creates etc/"otelcol-contrib"; update the post_install method to ensure the var/"log" directory exists (e.g., create or mkpath var/"log") before the service starts so first-run logging won't fail; locate the post_install method and add the directory creation adjacent to the existing etc/"otelcol-contrib" creation, referencing the same var/"log" target used by log_path/error_log_path.
21-23: Minor: ensureetc/otelcol-contribcreation aligns with the caveats/config expectation.
post_installcreates(etc/"otelcol-contrib"), andcaveats+serviceboth reference#{etc}/otelcol-contrib/config.yaml. Since no defaultconfig.yamlis created here, this is fine if the user supplies it, but it’s worth double-checking that your tap/formula conventions always provide a config (otherwise users get a “missing config” on start).Not a blocker based on this PR alone.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Formula/otel-collector.rb` around lines 21 - 23, post_install currently only ensures the directory (etc/"otelcol-contrib") exists but caveats and service reference #{etc}/otelcol-contrib/config.yaml; update post_install (or the formula's caveats/service text) to be consistent by either creating a default config.yaml in post_install (e.g., install a minimal config template into etc/"otelcol-contrib"/config.yaml) or modify the caveats/service descriptions to explicitly state that the user must supply config.yaml before starting; locate the logic in the post_install method and the caveats/service strings to make this single consistent change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Formula/otel-collector.rb`:
- Around line 13-19: The service config sets log_path and error_log_path to
var/"log/otelcol-contrib.log" and var/"log/otelcol-contrib.err.log" but
post_install only creates etc/"otelcol-contrib"; update the post_install method
to ensure the var/"log" directory exists (e.g., create or mkpath var/"log")
before the service starts so first-run logging won't fail; locate the
post_install method and add the directory creation adjacent to the existing
etc/"otelcol-contrib" creation, referencing the same var/"log" target used by
log_path/error_log_path.
- Around line 21-23: post_install currently only ensures the directory
(etc/"otelcol-contrib") exists but caveats and service reference
#{etc}/otelcol-contrib/config.yaml; update post_install (or the formula's
caveats/service text) to be consistent by either creating a default config.yaml
in post_install (e.g., install a minimal config template into
etc/"otelcol-contrib"/config.yaml) or modify the caveats/service descriptions to
explicitly state that the user must supply config.yaml before starting; locate
the logic in the post_install method and the caveats/service strings to make
this single consistent change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a4f6d3fb-eb79-40a7-8ccf-8423b217561d
📒 Files selected for processing (1)
Formula/otel-collector.rb
Automated formula bump for
otel-collector.0.147.00.151.0