Skip to content

fix(ratelimit): keep the deadline differential inside one window - #8

Merged
yordis merged 2 commits into
mainfrom
yordis/test-ratelimit-deadline-window
Oct 30, 2026
Merged

yordis merged 2 commits into
mainfrom
yordis/test-ratelimit-deadline-window

Conversation

@yordis

@yordis yordis commented Oct 30, 2026

Copy link
Copy Markdown
Member
  • The blockUntilReady deadline differential failed on an unrelated docs PR because the first request sometimes landed close enough to a 10 s window boundary for the window to reset before the 400 ms timeout, so the two libraries saw different outcomes depending on when each ran.

…he window it runs

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ives the timeout so a boundary cannot flip it

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0034c1c3-1d58-42ae-abf7-1409c8a5c2f7
Commits

Reviewing files that changed from the base of the PR and between b01c3cd and b7510e8.

Files selected for processing: 1
  • packages/next-nats/tests/vitest/differential/ratelimit.behavior.differential.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis merged commit 3fde4d4 into main Oct 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant