Repository navigation
feat(typescript): generate typed attributes and metrics on the OpenTelemetry JavaScript API - #60
Merged
Merged
Conversation
yordis
commented
Oct 30, 2026
yordis
commented
Member
- Applications on the plain OpenTelemetry JavaScript API have no package that renders a registry into typed attributes and instruments without adopting Effect, so they keep hand-typing metric names, units and attribute keys that drift from the registry.
- Spans, events and entities are left for a later version so the metrics surface can land and be consumed first.
…lemetry JavaScript API Applications that use the plain OpenTelemetry API had no package that renders a registry into typed attributes and instruments without adopting Effect. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryMedium Risk Overview Validation and CI: The suite includes broad golden Reviewed by Cursor Bugbot for commit 31d2831. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Important Review skippedToo many files! This PR contains 191 files, which is 91 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
 |
Unit and description stay inside the instrument, as the Go and Rust packages keep them, so callers have one registry constant to depend on. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
esbuild kept every generated class whenever an application imported one metric, and a build for a release before ES2022 paid a WeakMap lookup on every recording. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…rated metrics Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 50b637b. Configure here.
Code that needs only a metric name, such as an SDK view, should not bundle the instrument class. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…only as const already rejects reassignment, so freezing every constant at load added runtime work without adding safety. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
YAML .inf and .nan passed as numbers, so generation failed later with an opaque error or emitted bucket boundaries the SDK cannot use. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.