Repository navigation
feat(python): add typed metrics template package - #61
Merged
Merged
Conversation
yordis
commented
Oct 30, 2026
yordis
commented
Member
- Python code that records metrics by hand-typed name, unit and attribute keys drifts from the registry, and no package here renders a registry into Python.
- Importing the generated code needs only opentelemetry-api, so scripts that report through another channel can still take names from the registry.
- Spans, events and entities are left for a later version so the metrics surface can land and be consumed first.
Python services that record metrics by hand-typed name, unit, and attribute keys drift from the registry. This package generates typed instruments on the vanilla opentelemetry-api, so the registry stays the single source of truth and importing the output needs no SDK. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview Validation and CI: New Docs: README lists the Python package; AGENTS/CONTRIBUTING describe how to run and what generated Python must satisfy. Tests: Broad fixture suite—happy paths (attributes, metrics, filtering, histogram boundaries, imports) and many Reviewed by Cursor Bugbot for commit 04e009f. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Important Review skippedToo many files! This PR contains 230 files, which is 130 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
 |
Unit, description, kind and bucket boundaries stay inside the instrument, as the Go, Rust and TypeScript packages keep them, so callers have one registry constant to depend on. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f8599ba. Configure here.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.