Repository navigation
feat: scaffold and migrate for Trokky 3.0, where the site mounts the Studio - #5
Merged
Merged
Conversation
…Studio 'trokky create' emits server.ts that imports studioRouter from '@trokky/studio/express' and mounts it before any catch-all, forwards the top-level structure, and writes a trokky.config.ts whose studio block holds only branding. All generated projects pin the @Trokky packages to ^3.0.0. 'trokky migrate' pins to ^3.0.0 and gains a studio-mount warning: the pre-3.0 idioms (studioPath in mount(), getMountedStudioPath(), info.studioPath, enabled/path/requireAuth/apiUrl or structure inside the studio block, the dist/server/assets.js import) are reported with the replacement. They are not rewritten: the fix is two lines whose right place, before the site's own catch-all, a text rewrite cannot know, and the server refuses the old shape at boot so nothing can slip through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'trokky create' emits server.ts that imports studioRouter from
'@trokky/studio/express' and mounts it before any catch-all, forwards the
top-level structure, and writes a trokky.config.ts whose studio block holds
only branding. All generated projects pin the @Trokky packages to ^3.0.0.
'trokky migrate' pins to ^3.0.0 and gains a studio-mount warning: the
pre-3.0 idioms (studioPath in mount(), getMountedStudioPath(), info.studioPath,
enabled/path/requireAuth/apiUrl or structure inside the studio block, the
dist/server/assets.js import) are reported with the replacement. They are not
rewritten: the fix is two lines whose right place, before the site's own
catch-all, a text rewrite cannot know, and the server refuses the old shape
at boot so nothing can slip through.