Repository navigation
0.1.4: a call's audio from another site's copy - #1
Merged
Merged
Conversation
Trunk Recorder Pro's systems now have sites (trunk-recorder-plugin 0.4.0): a call heard on several starts and ends once, by its first site's copy, and its live audio comes from whichever copy has it, which can have another call id. Such audio now finds the call by its system and talkgroup, and calls are kept even when that first copy isn't recorded, so a stream on a patched talkgroup still gets it, with its radio and frequency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trunk Recorder Pro now has systems with sites (TrunkRecorder/trunk-recorder-pro#51; SDK
trunk-recorder-plugin0.4.0). A call heard on several sites starts and ends once, using the first site's copy, andshort_nameis always the system's. Its live audio comes from whichever site's copy has it at that moment, which may be a different copy with a differentcall_id.The problem: the plugin looked calls up by
call_id. Audio from another site's copy missed the lookup, so a stream set to a patched talkgroup lost it, and JSON packets went out withsrc: -1andfreq: 0. It also returned early on a call whose first copy wasn't recorded, while another site's copy was.What changes
call_idfinds its call by system and talkgroup.call_startpacket is still sent only for recorded calls, as before.Tests: new test
audio_from_another_sites_copy, which fails without the fix. All 11 tests pass, and clippy andcargo fmt --checkare clean.Release after merge: tag
v0.1.4, then a registry PR.🤖 Generated with Claude Code