Conversation
Try
reviewed
Sep 28, 2026
|
|
||
| Widget* customRoot = nullptr; | ||
| std::weak_ptr<Widget::Ref> mouseUp[Event::MouseButton::ButtonLast]; | ||
| std::map<MouseCapture,std::weak_ptr<Widget::Ref>> mouseUp; |
Owner
There was a problem hiding this comment.
Whole std::map is too heavy container for this use-case. In most cases this container will have 0-2 entries. Something like flat_map would be the right tool in principle, but it requires C++23.
Something like this should fit better:
struct MouseCapture {
Event::MouseButton button = {};
int id = 0;
std::weak_ptr<Widget::Ref> ref = {};
};
std::vector<MouseCapture> mouseUp;
Contributor
Author
There was a problem hiding this comment.
Replaced the map with a vector of MouseCapture, as suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture is currently stored by mouse button, so a second touch overwrites the
first one. Use the pointer ID as well, and don't treat a press from another
pointer as a double-click.
Enable multitouch on the controller's input view, including when Metal replaces it.
Adds regression tests for simultaneous touches, release order, mouse buttons,
re-entry and widget deletion. Tested with TempestTests on Windows, Linux and
locally on macOS, plus two-finger gestures in the iOS 18 and 27 simulators.